test: skip cycles

Author: dominykas

test/fixtures/cycle-a.json

@@ -0,0 +1,8 @@
+{
+  "private": true,
+  "name": "@example/cycle-a",
+  "version": "0.0.0",
+  "dependencies": {
+    "@example/cycle-b": "*"
+  }
+}

test/fixtures/cycle-b.json

@@ -0,0 +1,8 @@
+{
+  "private": true,
+  "name": "@example/cycle-b",
+  "version": "0.0.0",
+  "dependencies": {
+    "@example/cycle-a": "*"
+  }
+}

test/fixtures/deep.json

@@ -3,7 +3,8 @@
   "name": "@example/deep",
   "version": "0.0.0",
   "dependencies": {
-    "@example/basic": "*"
+    "@example/basic": "*",
+    "@example/with-preinstall-script": "*"
   },
   "allowScripts": {
     "@example/basic": "*",

test/fixtures/with-cycles.json

@@ -0,0 +1,13 @@
+{
+  "private": true,
+  "name": "@example/with-cycles",
+  "version": "0.0.0",
+  "dependencies": {
+    "@example/cycle-a": "*",
+    "@example/cycle-b": "*",
+    "@example/with-install-script": "*"
+  },
+  "allowScripts": {
+    "@example/with-install-script": "*"
+  }
+}

test/index.js

@@ -77,6 +77,21 @@ describe('allow-scripts', () => {
             expect(fixture.getLog()).not.to.contain('without-install-scripts');
         });
 
+        it('executes allowed scripts (skips cycles)', async () => {
+
+            const fixture = Fixtures.setup('with-cycles', [
+                'cycle-a',
+                'cycle-b',
+                'with-install-script'
+            ]);
+
+            await Allow.run({});
+
+            expect(fixture.getActualResult()).to.equal('install from with-install-script');
+            expect(fixture.getLog()).to.contain('skip node_modules/@example/cycle-a (because it has a cycle in dependencies)');
+            expect(fixture.getLog()).to.contain('skip node_modules/@example/cycle-b (because it has a cycle in dependencies)');
+        });
+
         it('crashes on script not in allowed list', async () => {
 
             const fixture = Fixtures.setup('not-in-allowed', [