fix: only call runScript when relevant script actually exists

Author: dominykas

lib/index.js

@@ -53,7 +53,7 @@ internals.runScript = (stage, { pkg, path, cwd, unsafePerm }, options) => {
     console.log();
 
     if (options.dryRun) {
-        console.log(`DRY RUN ==> ${stage} ${path || pkg.name}...`);
+        console.log(`DRY RUN ==> ${stage} ${path || pkg.name}`);
         return;
     }
 
@@ -146,15 +146,21 @@ exports.run = async (options) => {
     await internals.runScript('preinstall', { pkg, path: '', cwd, unsafePerm: true }, options);
 
     for (const { path, childPkg } of allowedPackages) {
-        await internals.runScript('preinstall', { pkg: childPkg, path, cwd }, options);
+        if (childPkg.scripts.preinstall) {
+            await internals.runScript('preinstall', { pkg: childPkg, path, cwd }, options);
+        }
     }
 
     for (const { path, childPkg } of allowedPackages) {
-        await internals.runScript('install', { pkg: childPkg, path, cwd }, options);
+        if (childPkg.scripts.install) {
+            await internals.runScript('install', { pkg: childPkg, path, cwd }, options);
+        }
     }
 
     for (const { path, childPkg } of allowedPackages) {
-        await internals.runScript('postinstall', { pkg: childPkg, path, cwd }, options);
+        if (childPkg.scripts.postinstall) {
+            await internals.runScript('postinstall', { pkg: childPkg, path, cwd }, options);
+        }
     }
 
     await internals.runScript('install', { pkg, path: '', cwd, unsafePerm: true }, options);

package.json

@@ -7,7 +7,7 @@
     "url": "https://github.com/dominykas/allow-scripts.git"
   },
   "scripts": {
-    "test": "lab -L -t 93 -m 5000"
+    "test": "lab -L -t 96 -m 5000"
   },
   "bin": {
     "allow-scripts": "./bin/allow-scripts.js"

test/fixtures/basic.dry-run.txt

@@ -0,0 +1,15 @@
+DRY RUN ==> preinstall @example/basic
+
+DRY RUN ==> preinstall node_modules/@example/with-preinstall-script
+
+DRY RUN ==> install node_modules/@example/with-install-script
+
+DRY RUN ==> postinstall node_modules/@example/with-postinstall-script
+
+DRY RUN ==> install @example/basic
+
+DRY RUN ==> postinstall @example/basic
+
+DRY RUN ==> prepublish @example/basic
+
+DRY RUN ==> prepare @example/basic

test/index.js

@@ -45,6 +45,22 @@ describe('allow-scripts', () => {
             expect(fixture.getLog()).not.to.contain('without-install-scripts');
         });
 
+        it('dry run: reports allowed scripts', async () => {
+
+            const fixture = Fixtures.setup('basic', [
+                'with-preinstall-script',
+                'with-install-script',
+                'with-postinstall-script',
+                'without-scripts',
+                'without-install-scripts'
+            ]);
+
+            await Allow.run({ dryRun: true });
+
+            expect(fixture.getActualResult()).to.equal('');
+            expect(fixture.getLog()).to.equal(Fs.readFileSync(Path.join(__dirname, 'fixtures', 'basic.dry-run.txt')).toString().trim());
+        });
+
         it('crashes on script not in allowed list', async () => {
 
             const fixture = Fixtures.setup('not-in-allowed', [