Return 0 when UInt byte is empty

8ctopus · web-flow · commit 7e932e3d4d96 · 2026-01-08T09:08:59.000-05:00
addresses PHP 8.5 deprecation fixes #151
diff --git a/src/FontLib/BinaryStream.php b/src/FontLib/BinaryStream.php
@@ -158,7 +158,11 @@ public function write($data, $length = null) {
   }
 
   public function readUInt8() {
-    return ord($this->read(1));
+    $byte = $this->read(1);
+    if ($byte === '') {
+      return 0;
+    }
+    return ord($byte);
   }
 
   public function readUInt8Many($count) {

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,11 @@ public function write($data, $length = null) {`
`158`	`158`	`}`
`159`	`159`
`160`	`160`	`public function readUInt8() {`
`161`		`- return ord($this->read(1));`
	`161`	`+ $byte = $this->read(1);`
	`162`	`+ if ($byte === '') {`
	`163`	`+ return 0;`
	`164`	`+ }`
	`165`	`+ return ord($byte);`
`162`	`166`	`}`
`163`	`167`
`164`	`168`	`public function readUInt8Many($count) {`