Skip to content

Commit b6d1204

Browse files
committed
remove font-awesome-webpack dependency
1 parent 16c5b5b commit b6d1204

File tree

11 files changed

+19
-96
lines changed

11 files changed

+19
-96
lines changed

.bootstraprc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"bootstrapVersion": 3,
33
"preBootstrapCustomizations": "./src/theme/variables.scss",
4-
"appStyles": "./src/theme/bootstrap.overrides.scss",
4+
"appStyles": "./src/theme/app.scss",
55
"loglevel": "disabled",
66
"env": {
77
"development": {

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ This is a starter boilerplate app I've put together using the following technolo
3030
* [lru-memoize](https://github.com/erikras/lru-memoize) to speed up form validation
3131
* [multireducer](https://github.com/erikras/multireducer) to combine single reducers into one key-based reducer
3232
* [style-loader](https://github.com/webpack/style-loader), [sass-loader](https://github.com/jtangelder/sass-loader) and [less-loader](https://github.com/webpack/less-loader) to allow import of stylesheets in plain css, sass and less,
33-
* [bootstrap-loader](https://github.com/shakacode/bootstrap-loader) and [font-awesome-webpack](https://github.com/gowravshekar/font-awesome-webpack) to customize Bootstrap and FontAwesome
33+
* [bootstrap-loader](https://github.com/shakacode/bootstrap-loader) to customize Bootstrap
34+
* [font-awesome](https://github.com/FortAwesome/Font-Awesome)
3435
* [react-helmet](https://github.com/nfl/react-helmet) to manage title and meta tag information on both server and client
3536
* [webpack-isomorphic-tools](https://github.com/halt-hammerzeit/webpack-isomorphic-tools) to allow require() work for statics both on client and server
3637
* [Jest](https://facebook.github.io/jest/) and [mocha](https://mochajs.org/) to allow writing unit tests for the project.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,6 @@
190190
"extract-text-webpack-plugin": "3.0.0",
191191
"file-loader": "^0.11.2",
192192
"font-awesome": "^4.7.0",
193-
"font-awesome-webpack": "^0.0.5-beta.2",
194193
"happypack": "^3.0.2",
195194
"html-webpack-plugin": "^2.30.1",
196195
"husky": "^0.14.3",

src/containers/Home/Home.js

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,9 @@ export default class Home extends Component {
2929
<img src={logoImage} alt="presentation" />
3030
</p>
3131
</div>
32-
<h1>
33-
{config.app.title}
34-
</h1>
32+
<h1>{config.app.title}</h1>
3533

36-
<h2>
37-
{config.app.description}
38-
</h2>
34+
<h2>{config.app.description}</h2>
3935

4036
<p>
4137
<a
@@ -47,7 +43,7 @@ export default class Home extends Component {
4743
<i className="fa fa-github" /> View on Github
4844
</a>
4945
</p>
50-
{online &&
46+
{online && (
5147
<GithubButton
5248
user="erikras"
5349
repo="react-redux-universal-hot-example"
@@ -56,8 +52,9 @@ export default class Home extends Component {
5652
height={30}
5753
count
5854
large
59-
/>}
60-
{online &&
55+
/>
56+
)}
57+
{online && (
6158
<GithubButton
6259
user="erikras"
6360
repo="react-redux-universal-hot-example"
@@ -66,7 +63,8 @@ export default class Home extends Component {
6663
height={30}
6764
count
6865
large
69-
/>}
66+
/>
67+
)}
7068

7169
<p className={styles.humility}>
7270
Created and maintained by{' '}
@@ -194,11 +192,12 @@ export default class Home extends Component {
194192
<a href="https://github.com/shakacode/bootstrap-sass-loader" target="_blank" rel="noopener noreferrer">
195193
bootstrap-sass-loader
196194
</a>{' '}
197-
and{' '}
198-
<a href="https://github.com/gowravshekar/font-awesome-webpack" target="_blank" rel="noopener noreferrer">
199-
font-awesome-webpack
200-
</a>{' '}
201-
to customize Bootstrap and FontAwesome
195+
to customize Bootstrap
196+
</li>
197+
<li>
198+
<a href="https://github.com/FortAwesome/Font-Awesome" target="_blank" rel="noopener noreferrer">
199+
font-awesome
200+
</a>
202201
</li>
203202
<li>
204203
<a href="http://socket.io/">socket.io</a> for real-time communication

src/theme/bootstrap.overrides.scss renamed to src/theme/app.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
@import "~font-awesome/scss/font-awesome.scss";
2+
13
/**
24
* Override Bootstrap styles that you can't modify via variables here.
35
*

src/theme/buildExtractStylesLoader.js

Lines changed: 0 additions & 36 deletions
This file was deleted.

src/theme/font-awesome.config.js

Lines changed: 0 additions & 18 deletions
This file was deleted.

src/theme/font-awesome.config.less

Lines changed: 0 additions & 7 deletions
This file was deleted.

src/theme/font-awesome.config.prod.js

Lines changed: 0 additions & 15 deletions
This file was deleted.

webpack/dev.config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ var webpackConfig = module.exports = {
5151
'webpack-hot-middleware/client?path=http://' + host + ':' + port + '/__webpack_hmr',
5252
'react-hot-loader/patch',
5353
'bootstrap-loader',
54-
'font-awesome-webpack!./src/theme/font-awesome.config.js',
5554
'./src/client.js'
5655
]
5756
},

0 commit comments

Comments
 (0)