Skip to content

Commit a04c2bb

Browse files
committed
[SPARK-53646] Improve KubernetesMetricsInterceptorTest to verify http.request metric
### What changes were proposed in this pull request? This PR aims to improve `KubernetesMetricsInterceptorTest` to verify `http.request` metric additionally. ### Why are the changes needed? `http.request` metric is also important. ### Does this PR introduce _any_ user-facing change? No, this is a test-only improvement. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#326 from dongjoon-hyun/SPARK-53646. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
1 parent a6cbad6 commit a04c2bb

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

spark-operator/src/test/java/org/apache/spark/k8s/operator/metrics/source/KubernetesMetricsInterceptorTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ void testMetricsEnabled() {
9797
Meter metric = (Meter) metrics2.get(name);
9898
Assertions.assertEquals(metric.getCount(), 1);
9999
});
100+
Assertions.assertEquals(((Meter) metrics2.get("http.request")).getCount(), 2);
100101
client.resource(sparkApplication).delete();
101102
}
102103
}
@@ -122,6 +123,7 @@ void testWhenKubernetesServerNotWorking() {
122123
Assertions.assertEquals(12, map.size());
123124
Meter metric = (Meter) map.get("failed");
124125
Assertions.assertEquals(metric.getCount(), retry + 1);
126+
Assertions.assertEquals(((Meter) map.get("http.request")).getCount(), retry + 1);
125127
}
126128
}
127129

0 commit comments

Comments
 (0)