Skip to content

Commit 083daf8

Browse files
fix: fix image dimensions and positioning for all sizes (#183)
1 parent 40113c2 commit 083daf8

File tree

2 files changed

+33
-17
lines changed

2 files changed

+33
-17
lines changed

clips/popup-banner/clip/clip.css

Lines changed: 28 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,12 @@
200200
stroke: var(--cta-color);
201201
}
202202

203+
.product-image-container{
204+
width:100%;
205+
height: 100%;
206+
position: absolute;
207+
}
208+
203209
.products .product-image {
204210
width: 450px;
205211
height: 450px;
@@ -209,8 +215,10 @@
209215
object-position: center;
210216
}
211217

212-
.shape {
213-
margin-left: 50px;
218+
.product-image.shape {
219+
width: 395px;
220+
height: 395px;
221+
margin-left: 40px;
214222
clip-path: path(
215223
"M272.509 2.45703C310.974 -3.41633 341.724 14.4616 363.099 48.0117C384.488 81.5846 396.463 130.828 397.282 187.527C398.101 244.182 381.427 295.694 350.419 333.238C319.659 370.482 274.773 394.005 218.783 395.17L217.459 395.192C206.459 395.351 194.839 391.522 183.156 385.128C171.477 378.735 159.765 369.796 148.593 359.778C127.643 340.994 108.63 318.457 95.3154 301.914L92.7295 298.688C86.0205 290.288 76.7017 280.953 66.6572 270.767C56.6035 260.571 45.8087 249.508 36.1084 237.622C17.0006 214.209 2.2184 187.697 5.65723 158.463L5.83496 157.068C13.134 103.842 33.8317 76.5112 61.5146 60.2256C75.377 52.0705 91.0139 46.6714 107.651 42.1934C123.274 37.9884 139.686 34.6169 156.377 30.5195L159.719 29.6904C204.716 18.389 232.652 8.71432 270.69 2.73828L272.509 2.45703Z"
216224
);
@@ -293,14 +301,16 @@
293301
}
294302

295303
.products .product-image {
296-
width: 230px;
297-
height: 230px;
304+
width: 278px;
305+
height: 232px;
298306
top: 5px;
307+
margin-left: 36px;
299308
}
300309

301-
.shape {
302-
top: 0;
303-
margin-left: 0px;
310+
.product-image.shape {
311+
width: 230px;
312+
height: 230px;
313+
margin-left: 55px;
304314
clip-path: path(
305315
"M230.12 108.708C231.068 174.306 191.511 228.066 125.913 229.014C100.213 229.385 69.0626 192.494 53.6009 173.135C38.1392 153.775 -1.43181 125.746 3.32315 91.0711C11.7792 29.4067 51.332 27.5488 92.4703 17.2165C118.861 10.5882 135.138 4.91457 157.68 1.47267C202.414 -5.35786 229.172 43.1109 230.12 108.708Z"
306316
);
@@ -430,11 +440,14 @@
430440
.products .product-image {
431441
width: 200px;
432442
height: 150px;
433-
top: 2px;
443+
top: 0px;
434444
}
435445

436-
.shape {
446+
.product-image.shape {
447+
width: 177px;
448+
height: 170px;
437449
margin-left: 15px;
450+
top: 2px;
438451
clip-path: path(
439452
"M174.052 69.2385C174.656 111.032 144.548 145.354 94.7767 146.074C75.2767 146.356 51.7072 122.906 40.0101 110.598C28.3131 98.2897 -1.6609 80.5008 2.00772 58.3996C8.53188 19.0956 38.5446 17.8423 69.7751 11.1868C89.8098 6.91723 102.17 3.27366 119.278 1.04105C153.231 -3.38963 173.447 27.445 174.052 69.2385Z"
440453
);
@@ -605,11 +618,13 @@
605618
top: 0px;
606619
}
607620

608-
.shape {
609-
top: 11px !important;
610-
margin-left: 20px;
621+
.product-image.shape {
622+
top: 9px;
623+
margin-left: 8px;
624+
width: 86px;
625+
height: 86px;
611626
clip-path: path(
612-
"M80.9442 32.7766C81.2322 52.7026 67.2358 69.0616 44.0883 69.3962C35.0194 69.5273 24.0538 58.3429 18.6117 52.4728C13.1696 46.6028 -0.773605 38.1165 0.928846 27.5799C3.95643 8.84196 17.9144 8.24951 32.4379 5.08164C41.7548 3.04942 47.5025 1.31436 55.459 0.252805C71.2487 -1.85387 80.6562 12.8506 80.9442 32.7766Z"
627+
"M84.3386 35.0859C84.6409 55.997 70.192 73.1612 46.29 73.5067C36.9254 73.6421 25.5996 61.9022 19.9786 55.7406C14.3577 49.5791 -0.0421655 40.6699 1.71323 29.6128C4.83496 9.94936 19.2479 9.33103 34.2441 6.01009C43.8643 3.87968 49.7989 2.06025 58.0146 0.948155C74.3186 -1.25882 84.0363 14.1748 84.3386 35.0859Z"
613628
);
614629
}
615630

clips/popup-banner/clip/clip.html

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,30 +105,31 @@
105105
<div class="product">
106106
<picture
107107
mc-if="initParams.imageClipPath == false"
108-
class="product-image"
108+
class="product-image-container"
109109
>
110110
<source
111111
mc-for="imgKey,imgItem"
112112
mc-of="item.featured_image"
113113
mc-if="{{imgKey}}!='default'"
114114
srcset="{{imgItem}}"
115115
media="{{imgKey}}"
116-
class="product-image"
117116
/>
118117
<img
119118
src="{{item.featured_image.default}}"
120119
alt="product"
121120
class="product-image"
122121
/>
123122
</picture>
124-
<picture mc-if="initParams.imageClipPath == true" class="product-image">
123+
<picture
124+
mc-if="initParams.imageClipPath == true"
125+
class="product-image-container"
126+
>
125127
<source
126128
mc-for="imgKey,imgItem"
127129
mc-of="item.featured_image"
128130
mc-if="{{imgKey}}!='default'"
129131
srcset="{{imgItem}}"
130132
media="{{imgKey}}"
131-
class="shape product-image"
132133
/>
133134
<img
134135
src="{{item.featured_image.default}}"

0 commit comments

Comments
 (0)