Use only the builtin version of eglot

[basus]

Eglot has been a part of the standard Emacs distribution for a while now. Doom's (lsp +eglot) module pins eglot to a particular version uses a version downloaded via straight. However this causes problems because eglot depends on jsonrpc (also via straight), but the two are not kept in sync. In fact, the current version of eglot does not work with the current version of jsonrpc. These are now both part of the standard Emacs distribution where they are updated together. Doom should unpin eglot and remove it from the list of packages it manages on its own and rely only on the builtin version.

[hlissner]

In fact, the current version of eglot does not work with the current version of jsonrpc

How so? Can you link any upstream issues?

Relying on the installed version of any built-in package introduces a lot of maintenance headaches I'd like to avoid (because users install a wide range of different Emacs versions). If the incompatibilities can be resolved out of band, trivially (by perhaps pinning eglot/jsonrpc to the nearest compatible version), I'd prefer to do that.

(Side note: eglot and jsonrpc are, by default, installed from their emacs-straight mirrors (jsonrpc, eglot), which I think are more up-to-date than the GNU ELPA sources)

[hlissner]

After some quick tests, it seems the current HEAD of emacs-straight/jsonrpc works with the currently pinned commit of Eglot. Since jsonrpc isn't pinned, there are ways for users to end up with an outdated jsonrpc (say, if they're not using doom upgrade and/or forget to run doom sync -u). I'll pin jsonrpc tomorrow to rectify that.

[basus]

I didn't realize that they were both installed from their straight mirrors, I actually had a hard time figuring out where they were coming from. If pinning works, I would be ok with that. I started to use (package! eglot :built-in 'prefer) for my own config, but doing doom sync -u has fixed the issue. For some reason I thought that doom sync (without the u flag) also updated packages and was confused when that didn't help.

[hlissner]

Understandable. doom sync updates pinned packages (if their pin changes), but doom sync -u is needed to update unpinned packages.

In any case, jsonrpc is now pinned, which should fix the original the issue. Let me know if that gives you trouble.