Refactor compile-time logic

Only compile snippets if package is being byte-compiled.

Author: hlissner

doom-snippets.el

@@ -25,9 +25,13 @@
      "snippets"
      (file-name-directory
       (cond (load-in-progress load-file-name)
-            ((and (boundp 'byte-compile-current-file) byte-compile-current-file)
+            ((bound-and-true-p byte-compile-current-file)
              byte-compile-current-file)
-            (buffer-file-name))))))
+            (buffer-file-name)))))
+
+  (when (bound-and-true-p byte-compile-current-file)
+    (require 'yasnippet)
+    (yas-compile-directory doom-snippets-dir)))
 
 (defvar doom-snippets-enable-short-helpers nil
   "If non-nil, defines convenience aliases for doom-snippets' api.
@@ -39,10 +43,6 @@
 + `%format' = `doom-snippet-format'
 + `%without-trigger' = `doom-snippets-without-trigger'")
 
-(eval-when-compile
-  (require 'yasnippet)
-  (yas-compile-directory doom-snippets-dir))
-
 ;;;###autoload
 (defun doom-snippets-remove-compiled-snippets ()
   "Delete all .yas-compiled-snippets.el files."