fix(UVE): Make computed be updated everytime the page asset changes (dotCMS#32140)

This pull request makes several updates to the `EditEmaEditorComponent`
and `withEditor` functions to clean up the code and improve
maintainability. The changes include removing commented-out code,
optimizing computed dependencies, and refining iframe URL generation
logic.

### Code cleanup:

* Removed a commented-out `console.log` statement from the
`EditEmaEditorComponent` to declutter the code and improve readability.
(`core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/edit-ema-editor.component.ts`)

### Optimization of computed dependencies:

* Updated the `$reloadEditorContent` computed property in `withEditor`
to directly use `store.isTraditionalPage()` instead of wrapping it with
`untracked`, simplifying the dependency logic.
(`core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/editor/withEditor.ts`)

### Improvements to iframe URL generation:

* Added comments and logic in the `$iframeURL` computed property to
explicitly import `pageAPIResponse()` for dependency tracking, ensuring
updates occur when the API response changes. This adjustment improves
future maintainability and aligns with planned UVE improvements.
(`core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/editor/withEditor.ts`)
* Refined the `$iframeURL` logic by removing outdated comments and
consolidating the `vanityURL` and `params.url` handling, ensuring
cleaner and more maintainable code.
(`core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/editor/withEditor.ts`)

### Video


https://github.com/user-attachments/assets/6af1dc01-f1ab-4e0a-90fa-e54e644fdff4

---------

Co-authored-by: Jalinson Diaz <[email protected]>

Author: rjvelazco

core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/edit-ema-editor.component.ts

@@ -1006,7 +1006,6 @@ export class EditEmaEditorComponent implements OnInit, OnDestroy {
             [CLIENT_ACTIONS.CLIENT_READY]: (devConfig) => {
                 const isClientReady = this.uveStore.isClientReady();
 
-                // console.log('isClientReady', isClientReady);
                 if (isClientReady) {
                     return;
                 }

core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/editor/withEditor.spec.ts

@@ -182,6 +182,28 @@ describe('withEditor', () => {
                 );
             });
 
+            // There is an issue with Signal Store when you try to spy on a signal called from a computed property
+            // Unskip this when this discussion is resolved: https://github.com/ngrx/platform/discussions/4627
+            describe.skip('pageAPIResponse dependency', () => {
+                it('should call pageAPIResponse when it is a headless page', () => {
+                    const spy = jest.spyOn(store, 'pageAPIResponse');
+                    patchState(store, { isTraditionalPage: false });
+                    store.$iframeURL();
+
+                    expect(spy).toHaveBeenCalled();
+                });
+
+                it('should call pageAPIResponse when it is a traditional page', () => {
+                    const spy = jest.spyOn(store, 'pageAPIResponse');
+
+                    patchState(store, { isTraditionalPage: true });
+
+                    store.$iframeURL();
+
+                    expect(spy).toHaveBeenCalled();
+                });
+            });
+
             it('should be an instance of String in src when the page is traditional', () => {
                 patchState(store, {
                     pageAPIResponse: MOCK_RESPONSE_VTL,

core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/editor/withEditor.ts

@@ -98,7 +98,7 @@ export function withEditor() {
                 $reloadEditorContent: computed<ReloadEditorContent>(() => {
                     return {
                         code: store.pageAPIResponse()?.page?.rendered,
-                        isTraditionalPage: untracked(() => store.isTraditionalPage()),
+                        isTraditionalPage: store.isTraditionalPage(),
                         enableInlineEdit:
                             store.isEditState() && untracked(() => store.isEnterprise())
                     };
@@ -207,7 +207,15 @@ export function withEditor() {
                     };
                 }),
                 $iframeURL: computed<string | InstanceType<typeof String>>(() => {
+                    /*
+                        Here we need to import pageAPIResponse() to create the computed dependency and have it updated every time a response is received from the PageAPI.
+                        This should change in future UVE improvements.
+                        More info: https://github.com/dotCMS/core/issues/31475 and https://github.com/dotCMS/core/issues/32139
+                     */
+                    const pageAPIResponse = store.pageAPIResponse();
+                    const vanityURL = pageAPIResponse?.vanityUrl?.url;
                     const isTraditionalPage = untracked(() => store.isTraditionalPage());
+                    const params = untracked(() => store.pageParams());
 
                     if (isTraditionalPage) {
                         // Force iframe reload on every page load to avoid caching issues and window dirty state
@@ -216,16 +224,7 @@ export function withEditor() {
                         return new String('');
                     }
 
-                    /*
-                        Here we need to import pageAPIResponse() to create the computed dependency and have it updated every time a response is received from the PageAPI.
-                        This should change in future UVE improvements.
-                        The url should not depend on the PageAPI response since it does not change (In traditional).
-                        In the future we should have a function that updates the content, independent of the url.
-                        More info: https://github.com/dotCMS/core/issues/31475
-                     */
-                    const vanityURL = store.pageAPIResponse()?.vanityUrl?.url;
-                    const url = sanitizeURL(vanityURL ?? untracked(() => store.pageParams().url));
-                    const params = untracked(() => store.pageParams());
+                    const url = sanitizeURL(vanityURL ?? params.url);
                     const dotCMSHost = dotWindow?.location?.origin;
 
                     return buildIframeURL({