chore: implement 404 strategy and remove logs (dotCMS#32998) (dotCMS#33001)

As discussed on the parent
[issue](dotCMS#32430 (comment))
a 404 strategy was added, and now the addPermissionsToCache function
doesn't log an error if the list of permissions is empty, it returns an
empty collection and puts on the cache a new object
`EmptyPermissionsCacheEntry` which will represent this 404 and expires
in 5 minutes.

Then when getting the permissions from the cache if it is this object
and it has expired then remove it from the cache and return null to
recalculate it.

This PR fixes: dotCMS#32998

---------

Co-authored-by: Daniel Silva <[email protected]>

Author: gortiz-dotcms

dotCMS/src/main/java/com/dotmarketing/business/PermissionCacheImpl.java

@@ -6,19 +6,24 @@
  */
 package com.dotmarketing.business;
 
+import com.dotcms.cache.Expirable;
 import com.dotmarketing.beans.Host;
 import com.dotmarketing.db.DbConnectionFactory;
-import com.dotmarketing.exception.DotDataException;
 import com.dotmarketing.portlets.contentlet.model.Contentlet;
+import com.dotmarketing.util.Config;
 import com.dotmarketing.util.UtilMethods;
 import com.liferay.portal.model.User;
 import com.liferay.util.StringPool;
+import java.io.Serializable;
+import java.time.LocalDateTime;
+import java.util.Collections;
 import java.util.List;
 
 import com.dotmarketing.beans.Permission;
 import com.dotmarketing.util.Logger;
 import java.util.Optional;
 import javax.validation.constraints.NotNull;
+import io.vavr.Lazy;
 
 /**
  *
@@ -28,6 +33,9 @@
  */
 public class PermissionCacheImpl extends PermissionCache {
 
+	static final Lazy<Integer> EMPTY_PERMISSIONS_TTL =
+			Lazy.of(() -> Config.getIntProperty("EMPTY_PERMISSIONS_TTL", 300)); // 5 minutes default
+
 	private DotCacheAdministrator cache;
 
 	private final String primaryGroup = "PermissionCache";
@@ -43,13 +51,13 @@ protected PermissionCacheImpl() {
 	 * @see com.dotmarketing.business.PermissionCache#addToPermissionCache(java.lang.String, java.util.List)
 	 */
 	protected List<Permission> addToPermissionCache(final String key, List<Permission> permissions) {
-	    if(permissions!=null && permissions.isEmpty()) {
-	        Logger.warn(this.getClass(), ()->" !!! Putting an empty list of permissions in the cache for asset:" + key +". Every asset should have at least 1 permission (or inherited permission) associated with it");
-			Thread.dumpStack();
-	    }
+		if (permissions != null && permissions.isEmpty()) {
+			cache.put(primaryGroup + key, new EmptyPermissionsCacheEntry(EMPTY_PERMISSIONS_TTL.get()), primaryGroup);
+			return Collections.emptyList();
+		}
 
         // Add the key to the cache
-        cache.put(primaryGroup + key, permissions,primaryGroup);
+        cache.put(primaryGroup + key, permissions, primaryGroup);
 
         return permissions;
     }
@@ -59,14 +67,25 @@ protected List<Permission> addToPermissionCache(final String key, List<Permissio
 	 */
     @SuppressWarnings("unchecked")
 	protected List<Permission> getPermissionsFromCache(String key) {
-    	key = primaryGroup + key;
-    	List<Permission> perms = null;
+    	final String cacheKey = primaryGroup + key;
+    	Object cachedObject = null;
     	try{
-    		perms = (List<Permission>) cache.get(key, primaryGroup);
+    		cachedObject = cache.get(cacheKey, primaryGroup);
     	}catch (DotCacheException e) {
 			Logger.debug(this,"Cache Entry not found", e);
 		}
-        return perms;
+
+		if (cachedObject instanceof EmptyPermissionsCacheEntry) {
+			final EmptyPermissionsCacheEntry entry = (EmptyPermissionsCacheEntry) cachedObject;
+			if (entry.isExpired()) {
+				cache.remove(cacheKey, primaryGroup);
+				return null;
+			}
+
+			return Collections.emptyList();
+		}
+
+        return (List<Permission>) cachedObject;
     }
 
     /* (non-Javadoc)
@@ -173,4 +192,24 @@ private Optional<String> shortLivedKey(@NotNull final Permissionable permissiona
 	public void flushShortTermCache() {
 		cache.flushGroup(shortLivedGroup);
 	}
+
+	/**
+	 * Cache entry for empty permissions with TTL expiration.
+	 * Implements the 404 strategy - cache empty results for a limited time to avoid repeated lookups.
+	 */
+	private static class EmptyPermissionsCacheEntry implements Serializable, Expirable {
+		private static final long serialVersionUID = 1L;
+
+		private final long ttl;
+		private final LocalDateTime since;
+
+		EmptyPermissionsCacheEntry(final long ttl) {
+			this.ttl = ttl;
+			this.since = LocalDateTime.now();
+		}
+
+		public boolean isExpired() {
+			return LocalDateTime.now().isAfter(since.plusSeconds(ttl));
+		}
+	}
 }