Skip to content

Commit c834d3d

Browse files
authored
Ensure WebAuthenticator URL is fully encoded to avoid issues with certain OAuth servers (#146)
Fixes #144
1 parent 3c02913 commit c834d3d

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/Directory.Build.targets

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717
<Authors>Morten Nielsen - https://xaml.dev</Authors>
1818
<Company>Morten Nielsen - https://xaml.dev</Company>
1919
<PackageIcon>logo.png</PackageIcon>
20-
<Version>2.3.2</Version>
21-
<PackageValidationBaselineVersion>2.3.1</PackageValidationBaselineVersion>
20+
<Version>2.3.3</Version>
21+
<PackageValidationBaselineVersion>2.3.2</PackageValidationBaselineVersion>
2222
</PropertyGroup>
2323

2424
<ItemGroup Condition="'$(PackageId)'!=''">

src/WinUIEx/WebAuthenticator.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ private async Task<WebAuthenticatorResult> Authenticate(Uri authorizeUri, Uri ca
260260

261261
var process = new System.Diagnostics.Process();
262262
process.StartInfo.FileName = "rundll32.exe";
263-
process.StartInfo.Arguments = $"url.dll,FileProtocolHandler \"{authorizeUri.ToString().Replace("\"","%22")}\"";
263+
process.StartInfo.Arguments = $"url.dll,FileProtocolHandler \"{authorizeUri.OriginalString}\"";
264264
process.StartInfo.UseShellExecute = true;
265265
process.Start();
266266
tasks.Add(taskId, tcs);

src/WinUIEx/WinUIEx.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
<PackageId>WinUIEx</PackageId>
2525
<Product>WinUI Extensions</Product>
2626
<PackageReleaseNotes>
27-
- Fixed WebAuthenticator issue not working with FireFox (#117)
27+
- Ensure WebAuthenticator URL is fully encoded to avoid issues with certain OAuth servers (#144)
2828
</PackageReleaseNotes>
2929
</PropertyGroup>
3030

0 commit comments

Comments
 (0)