Add special handling for identifiers which consist entirely of _ characters when transformUnderscore is true to emit valid Typescript syntax (#10412)

* Add special handling for identifiers that consist entirely of _ when we are asked to remove underscores. Added a test for this behaviour as well.

* Added changeset for change.

* Revert "Add special handling for identifiers that consist entirely of _ when we are asked to remove underscores. Added a test for this behaviour as well."

This reverts commit 3765f2a.

* Added more tightly scoped behaviour and test for enums from Typescript specifically.

* Update packages/plugins/other/visitor-plugin-common/src/base-types-visitor.ts

Co-authored-by: Eddy Nguyen <[email protected]>

---------

Co-authored-by: Eddy Nguyen <[email protected]>

Author: thekevinbrown

.changeset/strong-jars-fail.md

@@ -0,0 +1,5 @@
+---
+'@graphql-codegen/visitor-plugin-common': patch
+---
+
+Add special handling for identifiers that consist entirely of _ characters when transformUnderscore is true. This prevents _ values in GraphQL enums from being emitted without identifers in the resulting types.

packages/plugins/other/visitor-plugin-common/src/base-types-visitor.ts

@@ -493,6 +493,8 @@ export interface RawTypesConfig extends RawConfig {
   directiveArgumentAndInputFieldMappingTypeSuffix?: string;
 }
 
+const onlyUnderscoresPattern = /^_+$/;
+
 export class BaseTypesVisitor<
   TRawConfig extends RawTypesConfig = RawTypesConfig,
   TPluginConfig extends ParsedTypesConfig = ParsedTypesConfig
@@ -903,7 +905,9 @@ export class BaseTypesVisitor<
         const optionName = this.makeValidEnumIdentifier(
           this.convertName(enumOption, {
             useTypesPrefix: false,
-            transformUnderscore: true,
+            // We can only strip out the underscores if the value contains other
+            // characters. Otherwise we'll generate syntactically invalid code.
+            transformUnderscore: !onlyUnderscoresPattern.test(enumOption.name.value),
           })
         );
         const comment = this.getNodeComment(enumOption);

packages/plugins/typescript/typescript/tests/typescript.spec.ts

@@ -193,7 +193,7 @@ describe('TypeScript', () => {
       }`);
     });
 
-    it('Should removed underscore from enum values', async () => {
+    it('Should remove underscore from enum values', async () => {
       const schema = buildSchema(/* GraphQL */ `
         enum MyEnum {
           A_B_C
@@ -213,6 +213,24 @@ describe('TypeScript', () => {
       }`);
     });
 
+    it('Should leave underscores in enum values when the value is only underscores', async () => {
+      const schema = buildSchema(/* GraphQL */ `
+        enum MyEnum {
+          _
+          __
+          _TEST
+        }
+      `);
+      const result = await plugin(schema, [], {}, { outputFile: '' });
+
+      expect(result.content).toBeSimilarStringTo(`
+      export enum MyEnum {
+        _ = '_',
+        __ = '__',
+        Test = '_TEST'
+      }`);
+    });
+
     it('Should work with enum as const', async () => {
       const schema = buildSchema(/* GraphQL */ `
         enum MyEnum {