Are the custom fetcher docs wrong?

[jillesme]

Hello,

I am raising this question regarding: https://the-guild.dev/graphql/codegen/plugins/typescript/typescript-react-query#usage-example-isreacthook-false

There is the following example under "Usage example (isReactHook: false)":

// I have removed some of the config objects to focus more on the issue
export const fetchData = <TData, TVariables>(
  query: string,
  variables?: TVariables,
  options?: RequestInit['headers']
): (() => Promise<TData>) => {
  return async () => {
    const res = await fetch('https://api.url', {...});
    const json = await res.json()
 
    if (json.errors) {
      const { message } = json.errors[0] || {}
      throw new Error(message || 'Error…')
    }
 
    return json.data
  }
}

This method throws if there are any errors. This means we lose all the data that was successfully received. (e.g. https://www.apollographql.com/docs/react/data/error-handling/#graphql-error-policies).

Should it instead not be like the following, to still be able to use partial data?

export const fetchData = <TData, TVariables>(
  query: string,
  variables?: TVariables,
  options?: RequestInit['headers']
): (() => Promise<TData>) => {
  return async () => {
    const res = await fetch('https://api.url', {...});
    const json = await res.json()
 
    return { data: json.data, errors: json.errors }
  }
}