📌 ISSUE-#23: Updated unit tests

Author: FernandoCelmer

tests/core/decorators/test_action.py

@@ -9,17 +9,10 @@
 from dotflow.core.decorators.action import action
 
 
-def dummy_step():
-    pass
-
-
-def dummy_step_with_fail():
-    logging.error("Fail!")
-    raise Exception("Fail!")
-
-
-def dummy_step_previous_context(previous_context):
-    logging.debug(previous_context.storage)
+from tests.mocks import (
+    simple_step,
+    dummy_step_previous_context
+)
 
 
 class TestMethodAction(unittest.TestCase):
@@ -29,7 +22,7 @@ def inject_fixtures(self, caplog):
         self._caplog = caplog
 
     def test_instantiating_action_method(self):
-        inside = action(dummy_step)
+        inside = action(simple_step)
         decorated_function = inside()
 
         self.assertIsInstance(decorated_function, Context)

tests/core/test_actions.py tests/core/test_action.pytests/core/test_actions.py renamed to tests/core/test_action.py

@@ -8,18 +8,11 @@
 from dotflow.core.context import Context
 from dotflow.core.action import Action
 
-
-def dummy_step():
-    pass
-
-
-def dummy_step_with_fail():
-    logging.error("Fail!")
-    raise Exception("Fail!")
-
-
-def dummy_step_previous_context(previous_context):
-    logging.debug(previous_context.storage)
+from tests.mocks import (
+    simple_step,
+    dummy_step_previous_context,
+    dummy_step_with_fail
+)
 
 
 class TestClassActions(unittest.TestCase):
@@ -31,21 +24,21 @@ def inject_fixtures(self, caplog):
     def test_instantiating_action_class(self):
         number_of_retries = 1
 
-        inside = Action(dummy_step)
+        inside = Action(simple_step)
         decorated_function = inside()
 
         self.assertEqual(inside.retry, number_of_retries)
-        self.assertEqual(inside.func, dummy_step)
+        self.assertEqual(inside.func, simple_step)
         self.assertIsInstance(decorated_function, Context)
 
     def test_instantiating_action_class_with_retry(self):
         number_of_retries = 5
 
-        inside = Action(dummy_step, retry=number_of_retries)
+        inside = Action(simple_step, retry=number_of_retries)
         decorated_function = inside()
 
         self.assertEqual(inside.retry, number_of_retries)
-        self.assertEqual(inside.func, dummy_step)
+        self.assertEqual(inside.func, simple_step)
         self.assertIsInstance(decorated_function, Context)
 
     def test_instantiating_action_class_with_fail_retry(self):

tests/core/test_context.py

@@ -9,10 +9,18 @@
 class TestContext(unittest.TestCase):
 
     def setUp(self):
-        self.example = {"foo": "bar"}
+        self.content = {"foo": "bar"}
 
     def test_instantiating_class(self):
-        context = Context(storage=self.example)
+        context = Context(storage=self.content)
 
         self.assertIsInstance(context.time, datetime)
-        self.assertEqual(context.storage, self.example)
+        self.assertEqual(context.storage, self.content)
+
+    def test_instantiates_context_with_context(self):
+        context = Context(
+            storage=Context(storage=self.content)
+        )
+
+        self.assertIsInstance(context.time, datetime)
+        self.assertEqual(context.storage, self.content)

tests/core/test_task.py

@@ -4,16 +4,11 @@
 
 from dotflow.core.context import Context
 from dotflow.core.task import Task
-from dotflow.core.action import Action as action
 
-
-@action
-def dummy_step():
-    pass
-
-
-def dummy_callback(*args, **kwargs):
-    pass
+from tests.mocks import (
+    action_step,
+    simple_callback
+)
 
 
 class TestTask(unittest.TestCase):
@@ -27,8 +22,8 @@ def test_instantiating_class(self):
             initial_context=Context(
                 storage=self.example
             ),
-            step=dummy_step,
-            callback=dummy_callback
+            step=action_step,
+            callback=simple_callback
         )
 
     def test_task_id(self):
@@ -37,8 +32,8 @@ def test_task_id(self):
             initial_context=Context(
                 storage=self.example
             ),
-            step=dummy_step,
-            callback=dummy_callback
+            step=action_step,
+            callback=simple_callback
         )
 
         self.assertEqual(task.task_id, 0)
@@ -49,8 +44,8 @@ def test_initial_context(self):
             initial_context=Context(
                 storage=self.example
             ),
-            step=dummy_step,
-            callback=dummy_callback
+            step=action_step,
+            callback=simple_callback
         )
 
         self.assertEqual(

tests/core/test_task_build.py

@@ -3,14 +3,11 @@
 import unittest
 
 from dotflow.core.context import Context
+from dotflow.core.exception import MissingStepDecorator
 from dotflow.core.task import Task, TaskBuilder
-from dotflow.core.action import Action as action
 from dotflow.core.utils import callback
 
-
-@action
-def dummy_step():
-    pass
+from tests.mocks import action_step, simple_step
 
 
 class TestTaskBuild(unittest.TestCase):
@@ -25,7 +22,7 @@ def test_instantiating_class(self):
 
     def test_add_method(self):
         task = TaskBuilder()
-        task.add(step=dummy_step)
+        task.add(step=action_step)
 
         self.assertEqual(task.queu[0].task_id, 0)
         self.assertIsInstance(task.queu[0], Task)
@@ -35,7 +32,7 @@ def test_add_method(self):
     def test_add_method_with_class_context(self):
         task = TaskBuilder()
         task.add(
-            step=dummy_step,
+            step=action_step,
             initial_context=Context(
                 storage=self.example
             )
@@ -54,7 +51,7 @@ def test_add_method_with_class_context(self):
     def test_add_method_without_class_context(self):
         task = TaskBuilder()
         task.add(
-            step=dummy_step,
+            step=action_step,
             initial_context=self.example
         )
 
@@ -71,9 +68,30 @@ def test_add_method_without_class_context(self):
     def test_count_method(self):
         task = TaskBuilder()
 
-        initial_count = task.count()
-        self.assertEqual(initial_count, 0)
+        initial_count = 0
+        final_count = 1
+
+        self.assertEqual(task.count(), initial_count)
+
+        task.add(step=action_step)
+
+        self.assertEqual(task.count(), final_count)
+
+    def test_clear_method(self):
+        task = TaskBuilder()
+
+        expected_count_before = 1
+        expected_count_after = 0
+
+        task.add(step=action_step)
+        self.assertEqual(task.count(), expected_count_before)
+
+        task.clear()
+
+        self.assertEqual(task.count(), expected_count_after)
+
+    def test_with_step_without_decorator(self):
+        task = TaskBuilder()
 
-        task.add(step=dummy_step)
-        final_count = task.count()
-        self.assertEqual(final_count, 1)
+        with self.assertRaises(MissingStepDecorator):
+            task.add(step=simple_step)

tests/core/test_workflow.py

@@ -0,0 +1 @@
+"""Test context of workflow"""

tests/mocks.py

@@ -0,0 +1,27 @@
+"""Module Mock"""
+
+import logging
+
+from dotflow.core.action import Action as action
+
+
+@action
+def action_step() -> None:
+    pass
+
+
+def simple_step() -> None:
+    pass
+
+
+def simple_callback(*args, **kwargs):
+    pass
+
+
+def dummy_step_with_fail() -> None:
+    logging.error("Fail!")
+    raise Exception("Fail!")
+
+
+def dummy_step_previous_context(previous_context):
+    logging.debug(previous_context.storage)