Issue #415: Increased PHPStan level to 8

Signed-off-by: alexmerlin <[email protected]>

Author: alexmerlin

src/Core/src/Security/src/Entity/OAuthAccessToken.php

@@ -38,6 +38,7 @@ class OAuthAccessToken implements AccessTokenEntityInterface
     #[ORM\Column(name: 'user_id', type: 'string', length: 25, nullable: true)]
     private ?string $userId;
 
+    /** @var non-empty-string $token */
     #[ORM\Column(name: 'token', type: 'string', length: 100)]
     private string $token;
 
@@ -87,11 +88,17 @@ public function getClient(): ClientEntityInterface
         return $this->client;
     }
 
+    /**
+     * @return non-empty-string
+     */
     public function getToken(): string
     {
         return $this->token;
     }
 
+    /**
+     * @param non-empty-string $token
+     */
     public function setToken(string $token): self
     {
         $this->token = $token;
@@ -118,6 +125,9 @@ public function revoke(): self
         return $this;
     }
 
+    /**
+     * @return non-empty-string
+     */
     public function getIdentifier(): string
     {
         return $this->getToken();
@@ -202,12 +212,13 @@ public function initJwtConfiguration(): self
             throw new RuntimeException('Unable to init JWT without private key');
         }
 
+        /** @var non-empty-string $keyContents */
+        $keyContents = $this->privateKey->getKeyContents();
+        $passphrase  = (string) $this->privateKey->getPassPhrase();
+
         $this->jwtConfiguration = Configuration::forAsymmetricSigner(
             new Sha256(),
-            InMemory::plainText(
-                $this->privateKey->getKeyContents(),
-                $this->privateKey->getPassPhrase() ?? ''
-            ),
+            InMemory::plainText($keyContents, $passphrase),
             InMemory::plainText('/')
         );
 

src/Core/src/Security/src/Entity/OAuthClient.php

@@ -25,8 +25,9 @@ class OAuthClient implements ClientEntityInterface
     #[ORM\JoinColumn(name: 'user_id', referencedColumnName: 'uuid', nullable: true)]
     private ?User $user = null;
 
+    /** @var non-empty-string $name */
     #[ORM\Column(name: 'name', type: 'string', length: 40)]
-    private string $name = '';
+    private string $name;
 
     #[ORM\Column(name: 'secret', type: 'string', length: 100, nullable: true)]
     private ?string $secret = null;
@@ -69,18 +70,27 @@ public function getIdentity(): string
         return $this->getName();
     }
 
+    /**
+     * @return non-empty-string
+     */
     public function getIdentifier(): string
     {
         return $this->getName();
     }
 
+    /**
+     * @param non-empty-string $name
+     */
     public function setName(string $name): self
     {
         $this->name = $name;
 
         return $this;
     }
 
+    /**
+     * @return non-empty-string
+     */
     public function getName(): string
     {
         return $this->name;