Skip to content

Commit 7dad173

Browse files
committed
Fix dependency order & Removed packing gulp task
Packing a crx this way is not reliable and hack-y. The solution is to use the build-in "Pack extension" feature in chrome://extensions under developer mode
1 parent 534d164 commit 7dad173

File tree

3 files changed

+1
-20
lines changed

3 files changed

+1
-20
lines changed

gulpfile.js

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,6 @@ var size = require('gulp-filesize');
1212
var usemin = require('gulp-usemin');
1313
var rev = require('gulp-rev');
1414

15-
var fs = require("fs");
16-
var ChromeExtension = require("crx");
17-
var join = require("path").join;
18-
1915
gulp.task('default',['build', 'templates'], function(){
2016

2117
});
@@ -95,17 +91,3 @@ gulp.task('build',['templates'], function(){
9591
.pipe(size())
9692
.pipe(gulp.dest('dist/'));
9793
});
98-
99-
gulp.task('pack',['build'], function(){
100-
var crx = new ChromeExtension({
101-
codebase: "cardboard.crx",
102-
privateKey: fs.readFileSync("cardboard.pem")
103-
});
104-
105-
return crx.load('dist/')
106-
.then(function() {
107-
return crx.pack().then(function(crxBuffer){
108-
fs.writeFile('dist/cardboard.crx', crxBuffer);
109-
})
110-
});
111-
});

index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@
4747

4848
<!-- build:js cardboard.min.js-->
4949
<!-- inject:js -->
50-
<script src="/src/cardboard.js"></script>
5150
<script src="/src/filters/bootstrap.js"></script>
5251
<script src="/src/filters/Humanize.js"></script>
5352
<script src="/src/filters/Host.js"></script>
@@ -76,6 +75,7 @@
7675
<script src="/src/controllers/ChangelogCtrl.js"></script>
7776
<script src="/src/controllers/BookmarkCtrl.js"></script>
7877
<script src="/src/controllers/AppCtrl.js"></script>
78+
<script src="/src/cardboard.js"></script>
7979
<!-- endinject -->
8080
<!-- endbuild -->
8181

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
},
2828
"homepage": "https://github.com/virtual-dev/cardboard",
2929
"devDependencies": {
30-
"crx": "^3.0.2",
3130
"del": "^1.1.1",
3231
"event-stream": "^3.2.2",
3332
"gulp": "^3.8.11",

0 commit comments

Comments
 (0)