Removed lazy creation of PermissionsService on iOS and Android.

Author: David Britch

src/Mobile/eShopOnContainers/eShopOnContainers.Droid/Activities/MainActivity.cs

@@ -57,7 +57,7 @@ public override void OnTrimMemory([GeneratedEnum] TrimMemory level)
         public override void OnRequestPermissionsResult(int requestCode, string[] permissions, Permission[] grantResults)
         {
             base.OnRequestPermissionsResult(requestCode, permissions, grantResults);
-            ((PermissionsService)PermissionsService.Current.Value).OnRequestPermissionResult(requestCode, permissions, grantResults);
+            ((PermissionsService)PermissionsService.Instance).OnRequestPermissionResult(requestCode, permissions, grantResults);
         }
     }
 }

src/Mobile/eShopOnContainers/eShopOnContainers.Droid/Services/LocationServiceImplementation.cs

@@ -44,12 +44,12 @@ public LocationServiceImplementation()
 
         async Task<bool> CheckPermissionsAsync()
         {
-            var status = await PermissionsService.Current.Value.CheckPermissionStatusAsync(Permission.Location);
+            var status = await PermissionsService.Instance.CheckPermissionStatusAsync(Permission.Location);
             if (status != PermissionStatus.Granted)
             {
                 Console.WriteLine("Currently do not have Location permissions, requesting permissions.");
 
-                var request = await PermissionsService.Current.Value.RequestPermissionsAsync(Permission.Location);
+                var request = await PermissionsService.Instance.RequestPermissionsAsync(Permission.Location);
                 if (request[Permission.Location] != PermissionStatus.Granted)
                 {
                     Console.WriteLine("Location permission denied.");

src/Mobile/eShopOnContainers/eShopOnContainers.Droid/Services/PermissionsService.cs

@@ -8,7 +8,6 @@
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Linq;
-using System.Threading;
 using System.Threading.Tasks;
 
 namespace eShopOnContainers.Droid.Services
@@ -21,7 +20,7 @@ public class PermissionsService : IPermissionsService
         Dictionary<Permission, PermissionStatus> _results;
         IList<string> _requestedPermissions;
 
-        public static Lazy<IPermissionsService> Current = new Lazy<IPermissionsService>(() => new PermissionsService(), LazyThreadSafetyMode.PublicationOnly);
+        public static IPermissionsService Instance = new PermissionsService();
 
         #region Internal Implementation
 

src/Mobile/eShopOnContainers/eShopOnContainers.iOS/Services/LocationServiceImplementation.cs

@@ -15,24 +15,24 @@ namespace eShopOnContainers.iOS.Services
 {
     public class LocationServiceImplementation : ILocationServiceImplementation
     {
-        Lazy<IPermissionsService> _permissionsService;
+        IPermissionsService _permissionsService;
 
         public LocationServiceImplementation()
         {
             DesiredAccuracy = 100;
-            _permissionsService = new Lazy<IPermissionsService>(() => new PermissionsService(), LazyThreadSafetyMode.PublicationOnly);
+            _permissionsService = new PermissionsService();
         }
 
         #region Internal Implementation
 
         async Task<bool> CheckPermissions(Permission permission)
         {
-            var status = await _permissionsService.Value.CheckPermissionStatusAsync(permission);
+            var status = await _permissionsService.CheckPermissionStatusAsync(permission);
             if (status != PermissionStatus.Granted)
             {
                 Console.WriteLine("Currently do not have Location permissions, requesting permissions");
 
-                var request = await _permissionsService.Value.RequestPermissionsAsync(permission);
+                var request = await _permissionsService.RequestPermissionsAsync(permission);
                 if (request[permission] != PermissionStatus.Granted)
                 {
                     Console.WriteLine("Location permission denied, can not get positions async.");