Merge remote-tracking branch 'upstream/dev' into dev

Robert Raboud · Robert Raboud · commit 5f644b8131fc · 2018-02-19T12:13:51.000-05:00
diff --git a/src/Mobile/eShopOnContainers/eShopOnContainers.Core/ViewModels/Base/ViewModelLocator.cs b/src/Mobile/eShopOnContainers/eShopOnContainers.Core/ViewModels/Base/ViewModelLocator.cs
@@ -42,7 +42,7 @@ static ViewModelLocator()
         {
             _container = new TinyIoCContainer();
 
-            // View models
+            // View models - by default, TinyIoC will register concrete classes as multi-instance.
             _container.Register<BasketViewModel>();
             _container.Register<CatalogViewModel>();
             _container.Register<CheckoutViewModel>();
@@ -54,43 +54,43 @@ static ViewModelLocator()
             _container.Register<CampaignViewModel>();
             _container.Register<CampaignDetailsViewModel>();
 
-            // Services
-            _container.Register<INavigationService, NavigationService>().AsSingleton();
+            // Services - by default, TinyIoC will register interface registrations as singletons.
+            _container.Register<INavigationService, NavigationService>();
             _container.Register<IDialogService, DialogService>();
             _container.Register<IOpenUrlService, OpenUrlService>();
             _container.Register<IIdentityService, IdentityService>();
             _container.Register<IRequestProvider, RequestProvider>();
             _container.Register<IDependencyService, Services.Dependency.DependencyService>();
-            _container.Register<ISettingsService, SettingsService>().AsSingleton();
-            _container.Register<IFixUriService, FixUriService>().AsSingleton();
-            _container.Register<ILocationService, LocationService>().AsSingleton();
-            _container.Register<ICatalogService, CatalogMockService>().AsSingleton();
-            _container.Register<IBasketService, BasketMockService>().AsSingleton();
-            _container.Register<IOrderService, OrderMockService>().AsSingleton();
-            _container.Register<IUserService, UserMockService>().AsSingleton();
-            _container.Register<ICampaignService, CampaignMockService>().AsSingleton();
+            _container.Register<ISettingsService, SettingsService>();
+            _container.Register<IFixUriService, FixUriService>();
+            _container.Register<ILocationService, LocationService>();
+            _container.Register<ICatalogService, CatalogMockService>();
+            _container.Register<IBasketService, BasketMockService>();
+            _container.Register<IOrderService, OrderMockService>();
+            _container.Register<IUserService, UserMockService>();
+            _container.Register<ICampaignService, CampaignMockService>();
         }
 
         public static void UpdateDependencies(bool useMockServices)
         {
             // Change injected dependencies
             if (useMockServices)
             {
-                _container.Register<ICatalogService, CatalogMockService>().AsSingleton();
-                _container.Register<IBasketService, BasketMockService>().AsSingleton();
-                _container.Register<IOrderService, OrderMockService>().AsSingleton();
-                _container.Register<IUserService, UserMockService>().AsSingleton();
-                _container.Register<ICampaignService, CampaignMockService>().AsSingleton();
+                _container.Register<ICatalogService, CatalogMockService>();
+                _container.Register<IBasketService, BasketMockService>();
+                _container.Register<IOrderService, OrderMockService>();
+                _container.Register<IUserService, UserMockService>();
+                _container.Register<ICampaignService, CampaignMockService>();
 
                 UseMockService = true;
             }
             else
             {
-                _container.Register<ICatalogService, CatalogService>().AsSingleton();
-                _container.Register<IBasketService, BasketService>().AsSingleton();
-                _container.Register<IOrderService, OrderService>().AsSingleton();
-                _container.Register<IUserService, UserService>().AsSingleton();
-                _container.Register<ICampaignService, CampaignService>().AsSingleton();
+                _container.Register<ICatalogService, CatalogService>();
+                _container.Register<IBasketService, BasketService>();
+                _container.Register<IOrderService, OrderService>();
+                _container.Register<IUserService, UserService>();
+                _container.Register<ICampaignService, CampaignService>();
 
                 UseMockService = false;
             }
diff --git a/src/Services/Catalog/Catalog.API/Infrastructure/CatalogContextSeed.cs b/src/Services/Catalog/Catalog.API/Infrastructure/CatalogContextSeed.cs
@@ -30,7 +30,7 @@ await policy.ExecuteAsync(async () =>
 
                 if (!context.CatalogBrands.Any())
                 {
-                    context.CatalogBrands.AddRange(useCustomizationData
+                    await context.CatalogBrands.AddRangeAsync(useCustomizationData
                         ? GetCatalogBrandsFromFile(contentRootPath, logger)
                         : GetPreconfiguredCatalogBrands());
 
@@ -39,7 +39,7 @@ await policy.ExecuteAsync(async () =>
 
                 if (!context.CatalogTypes.Any())
                 {
-                    context.CatalogTypes.AddRange(useCustomizationData
+                    await context.CatalogTypes.AddRangeAsync(useCustomizationData
                         ? GetCatalogTypesFromFile(contentRootPath, logger)
                         : GetPreconfiguredCatalogTypes());
 
@@ -48,7 +48,7 @@ await policy.ExecuteAsync(async () =>
 
                 if (!context.CatalogItems.Any())
                 {
-                    context.CatalogItems.AddRange(useCustomizationData
+                    await context.CatalogItems.AddRangeAsync(useCustomizationData
                         ? GetCatalogItemsFromFile(contentRootPath, context, logger)
                         : GetPreconfiguredItems());
 
diff --git a/src/Services/Identity/Identity.API/Data/ApplicationDbContextSeed.cs b/src/Services/Identity/Identity.API/Data/ApplicationDbContextSeed.cs
@@ -33,7 +33,7 @@ public async Task SeedAsync(ApplicationDbContext context,IHostingEnvironment env
 
                 if (!context.Users.Any())
                 {
-                    context.Users.AddRange(useCustomizationData
+                    await context.Users.AddRangeAsync(useCustomizationData
                         ? GetUsersFromFile(contentRootPath, logger)
                         : GetDefaultUser());
 
diff --git a/src/Services/Identity/Identity.API/Data/ConfigurationDbContextSeed.cs b/src/Services/Identity/Identity.API/Data/ConfigurationDbContextSeed.cs
@@ -27,17 +27,17 @@ public async Task SeedAsync(ConfigurationDbContext context, IConfiguration confi
 
             if (!await context.Clients.AnyAsync())
             {
-                context.Clients.AddRange(Config.GetClients(clientUrls).Select(client => client.ToEntity()));
+                await context.Clients.AddRangeAsync(Config.GetClients(clientUrls).Select(client => client.ToEntity()));
             }
 
             if (!await context.IdentityResources.AnyAsync())
             {
-                context.IdentityResources.AddRange(Config.GetResources().Select(resource => resource.ToEntity()));
+                await context.IdentityResources.AddRangeAsync(Config.GetResources().Select(resource => resource.ToEntity()));
             }
 
             if (!await context.ApiResources.AnyAsync())
             {
-                context.ApiResources.AddRange(Config.GetApis().Select(api => api.ToEntity()));
+                await context.ApiResources.AddRangeAsync(Config.GetApis().Select(api => api.ToEntity()));
             }
 
             await context.SaveChangesAsync();
diff --git a/src/Services/Marketing/Marketing.API/Infrastructure/MarketingContextSeed.cs b/src/Services/Marketing/Marketing.API/Infrastructure/MarketingContextSeed.cs
@@ -19,7 +19,7 @@ await policy.ExecuteAsync(async () =>
             {
                 if (!context.Campaigns.Any())
                 {
-                    context.Campaigns.AddRange(
+                    await context.Campaigns.AddRangeAsync(
                         GetPreconfiguredMarketings());
 
                     await context.SaveChangesAsync();
diff --git a/src/Services/Ordering/Ordering.API/Infrastructure/AutofacModules/MediatorModule.cs b/src/Services/Ordering/Ordering.API/Infrastructure/AutofacModules/MediatorModule.cs
@@ -19,11 +19,11 @@ protected override void Load(ContainerBuilder builder)
             builder.RegisterAssemblyTypes(typeof(IMediator).GetTypeInfo().Assembly)
                 .AsImplementedInterfaces();
 
-            // Register all the Command classes (they implement IAsyncRequestHandler) in assembly holding the Commands
+            // Register all the Command classes (they implement IRequestHandler) in assembly holding the Commands
             builder.RegisterAssemblyTypes(typeof(CreateOrderCommand).GetTypeInfo().Assembly)
                 .AsClosedTypesOf(typeof(IRequestHandler<,>));
 
-            // Register the DomainEventHandler classes (they implement IAsyncNotificationHandler<>) in assembly holding the Domain Events
+            // Register the DomainEventHandler classes (they implement INotificationHandler<>) in assembly holding the Domain Events
             builder.RegisterAssemblyTypes(typeof(ValidateOrAddBuyerAggregateWhenOrderStartedDomainEventHandler).GetTypeInfo().Assembly)
                 .AsClosedTypesOf(typeof(INotificationHandler<>));
 
diff --git a/src/Services/Ordering/Ordering.API/Infrastructure/OrderingContextSeed.cs b/src/Services/Ordering/Ordering.API/Infrastructure/OrderingContextSeed.cs
@@ -39,7 +39,7 @@ await policy.ExecuteAsync(async () =>
 
                     if (!context.CardTypes.Any())
                     {
-                        context.CardTypes.AddRange(useCustomizationData
+                        await context.CardTypes.AddRangeAsync(useCustomizationData
                                                 ? GetCardTypesFromFile(contentRootPath, logger)
                                                 : GetPredefinedCardTypes());
 
@@ -48,7 +48,7 @@ await policy.ExecuteAsync(async () =>
 
                     if (!context.OrderStatus.Any())
                     {
-                        context.OrderStatus.AddRange(useCustomizationData
+                        await context.OrderStatus.AddRangeAsync(useCustomizationData
                                                 ? GetOrderStatusFromFile(contentRootPath, logger)
                                                 : GetPredefinedOrderStatus());
                     }

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ await policy.ExecuteAsync(async () =>`
`30`	`30`
`31`	`31`	`if (!context.CatalogBrands.Any())`
`32`	`32`	`{`
`33`		`- context.CatalogBrands.AddRange(useCustomizationData`
	`33`	`+ await context.CatalogBrands.AddRangeAsync(useCustomizationData`
`34`	`34`	`? GetCatalogBrandsFromFile(contentRootPath, logger)`
`35`	`35`	`: GetPreconfiguredCatalogBrands());`
`36`	`36`
`@@ -39,7 +39,7 @@ await policy.ExecuteAsync(async () =>`
`39`	`39`
`40`	`40`	`if (!context.CatalogTypes.Any())`
`41`	`41`	`{`
`42`		`- context.CatalogTypes.AddRange(useCustomizationData`
	`42`	`+ await context.CatalogTypes.AddRangeAsync(useCustomizationData`
`43`	`43`	`? GetCatalogTypesFromFile(contentRootPath, logger)`
`44`	`44`	`: GetPreconfiguredCatalogTypes());`
`45`	`45`
`@@ -48,7 +48,7 @@ await policy.ExecuteAsync(async () =>`
`48`	`48`
`49`	`49`	`if (!context.CatalogItems.Any())`
`50`	`50`	`{`
`51`		`- context.CatalogItems.AddRange(useCustomizationData`
	`51`	`+ await context.CatalogItems.AddRangeAsync(useCustomizationData`
`52`	`52`	`? GetCatalogItemsFromFile(contentRootPath, context, logger)`
`53`	`53`	`: GetPreconfiguredItems());`
`54`	`54`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ public async Task SeedAsync(ApplicationDbContext context,IHostingEnvironment env`
`33`	`33`
`34`	`34`	`if (!context.Users.Any())`
`35`	`35`	`{`
`36`		`- context.Users.AddRange(useCustomizationData`
	`36`	`+ await context.Users.AddRangeAsync(useCustomizationData`
`37`	`37`	`? GetUsersFromFile(contentRootPath, logger)`
`38`	`38`	`: GetDefaultUser());`
`39`	`39`
Original file line number	Diff line number	Diff line change
`@@ -27,17 +27,17 @@ public async Task SeedAsync(ConfigurationDbContext context, IConfiguration confi`
`27`	`27`
`28`	`28`	`if (!await context.Clients.AnyAsync())`
`29`	`29`	`{`
`30`		`- context.Clients.AddRange(Config.GetClients(clientUrls).Select(client => client.ToEntity()));`
	`30`	`+ await context.Clients.AddRangeAsync(Config.GetClients(clientUrls).Select(client => client.ToEntity()));`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`if (!await context.IdentityResources.AnyAsync())`
`34`	`34`	`{`
`35`		`- context.IdentityResources.AddRange(Config.GetResources().Select(resource => resource.ToEntity()));`
	`35`	`+ await context.IdentityResources.AddRangeAsync(Config.GetResources().Select(resource => resource.ToEntity()));`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`if (!await context.ApiResources.AnyAsync())`
`39`	`39`	`{`
`40`		`- context.ApiResources.AddRange(Config.GetApis().Select(api => api.ToEntity()));`
	`40`	`+ await context.ApiResources.AddRangeAsync(Config.GetApis().Select(api => api.ToEntity()));`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`await context.SaveChangesAsync();`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ await policy.ExecuteAsync(async () =>`
`19`	`19`	`{`
`20`	`20`	`if (!context.Campaigns.Any())`
`21`	`21`	`{`
`22`		`- context.Campaigns.AddRange(`
	`22`	`+ await context.Campaigns.AddRangeAsync(`
`23`	`23`	`GetPreconfiguredMarketings());`
`24`	`24`
`25`	`25`	`await context.SaveChangesAsync();`