Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Commit 66c8a33

Browse files
committed
Add comments on deploy.sh limitations
1 parent fe0cea7 commit 66c8a33

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

k8s/deploy.sh

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,17 @@
33
# http://redsymbol.net/articles/unofficial-bash-strict-mode/
44
set -euo pipefail
55

6+
# This script is comparable to the PowerShell script deploy.ps1 but to be used from a Mac bash environment.
7+
# There are, however, the following few differences/limitations:
8+
9+
# It assumes docker/container registry login was already performed
10+
# It assumes K8s was given access to the registry—does not create any K8s secrets
11+
# It does not support explicit kubectl config file (relies on kubectl config use-context to point kubectl at the right cluster/namespace)
12+
# It always deploys infrastructure bits (redis, SQL Server etc)
13+
# The script was tested only with Azure Container Registry (not Docker Hub, although it is expected to work with Docker Hub too)
14+
15+
# Feel free to submit a PR in order to improve it.
16+
617
usage()
718
{
819
cat <<END
@@ -11,7 +22,7 @@ Parameters:
1122
-r | --registry <container registry>
1223
Specifies container registry (ACR) to use (required), e.g. myregistry.azurecr.io
1324
-t | --tag <docker image tag>
14-
Default: current timestamp, with 1-minute resolution
25+
Default: newly created, date-based timestamp, with 1-minute resolution
1526
-b | --build-solution
1627
Force solution build before deployment (default: false)
1728
--skip-image-build
@@ -31,6 +42,7 @@ FROM THE CURRENT CONFIGURATION CONTEXT.
3142
It is recommended that you create a separate namespace and confguration context
3243
for the eShopOnContainers application, to isolate it from other applications on the cluster.
3344
For more information see https://kubernetes.io/docs/tasks/administer-cluster/namespaces/
45+
You can use eshop-namespace.yaml file (in the same directory) to create the namespace.
3446
3547
END
3648
}

0 commit comments

Comments
 (0)