Don't read the file into memory

davidfowl · ReubenBond · commit 8debda5c6730 · 2023-05-09T07:05:39.000-07:00
diff --git a/src/Services/Catalog/Catalog.API/Controllers/PicController.cs b/src/Services/Catalog/Catalog.API/Controllers/PicController.cs
@@ -36,8 +36,6 @@ public async Task<ActionResult> GetImageAsync(int catalogItemId)
             string imageFileExtension = Path.GetExtension(item.PictureFileName);
             string mimetype = GetImageMimeTypeFromImageFileExtension(imageFileExtension);
 
-            var buffer = await System.IO.File.ReadAllBytesAsync(path);
-
             return PhysicalFile(path, mimetype);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -36,8 +36,6 @@ public async Task<ActionResult> GetImageAsync(int catalogItemId)`
`36`	`36`	`string imageFileExtension = Path.GetExtension(item.PictureFileName);`
`37`	`37`	`string mimetype = GetImageMimeTypeFromImageFileExtension(imageFileExtension);`
`38`	`38`
`39`		`- var buffer = await System.IO.File.ReadAllBytesAsync(path);`
`40`		`-`
`41`	`39`	`return PhysicalFile(path, mimetype);`
`42`	`40`	`}`
`43`	`41`