CatalogService: Fix issue with Status set when items list is empty (#1304)

* Fix issue with Status set when items list is empty

* Change method Count() call to Count property

Co-authored-by: Dmytro Hridin <[email protected]>

Author: dmytrohridin

src/Services/Catalog/Catalog.API/Grpc/CatalogService.cs

@@ -68,11 +68,10 @@ public override async Task<PaginatedItemsResponse> GetItemsByIds(CatalogItemsReq
             {
                 var items = await GetItemsByIdsAsync(request.Ids);
 
-                if (!items.Any())
-                {
-                    context.Status = new Status(StatusCode.NotFound, $"ids value invalid. Must be comma-separated list of numbers");
-                }
-                context.Status = new Status(StatusCode.OK, string.Empty);
+                context.Status = !items.Any() ?
+                    new Status(StatusCode.NotFound, $"ids value invalid. Must be comma-separated list of numbers") :
+                    new Status(StatusCode.OK, string.Empty);
+
                 return this.MapToResponse(items);
             }
 
@@ -104,7 +103,7 @@ public override async Task<PaginatedItemsResponse> GetItemsByIds(CatalogItemsReq
 
         private PaginatedItemsResponse MapToResponse(List<CatalogItem> items)
         {
-            return this.MapToResponse(items, items.Count(), 1, items.Count());
+            return this.MapToResponse(items, items.Count, 1, items.Count);
         }
 
         private PaginatedItemsResponse MapToResponse(List<CatalogItem> items, long count, int pageIndex, int pageSize)