Fixed issue header not included in requests

Fixed issue httpclient returned response

Author: Ramón Tomás

src/Web/WebMVC/wwwroot/js/site.js

@@ -81,7 +81,7 @@ export class BasketService {
             if (response.status === 204) {
                 return null;
             }
-            return response.json();
+            return response;
         }));
     }    
 

src/Web/WebMVC/wwwroot/js/site.min.js

@@ -33,15 +33,15 @@ export class CampaignsService {
         url = url + '?pageIndex=' + pageIndex + '&pageSize=' + pageSize;
 
         return this.service.get(url).pipe(map((response: Response) => {
-            return response.json();
+            return response;
         }));
     }
 
     getCampaign(id: number): Observable<ICampaignItem> {
         let url = this.marketingUrl + '/api/v1/m/campaigns/' + id;
 
         return this.service.get(url).pipe(map((response: Response) => {
-            return response.json();
+            return response;
         }));
     }    
 }

src/Web/WebSPA/Client/modules/basket/basket.service.ts

@@ -28,15 +28,15 @@ export class OrdersService {
         let url = this.ordersUrl + '/api/v1/o/orders';
 
         return this.service.get(url).pipe(map((response: Response) => {
-            return response.json();
+            return response;
         }));
     }
 
     getOrder(id: number): Observable<IOrderDetail> {
         let url = this.ordersUrl + '/api/v1/o/orders/' + id;
 
         return this.service.get(url).pipe(map((response: Response) => {
-            return response.json();
+            return response;
         }));
     }
 

src/Web/WebSPA/Client/modules/campaigns/campaigns.service.ts

@@ -1,5 +1,5 @@
-import { Injectable }       from '@angular/core';
-import { Http, Response, RequestOptionsArgs, RequestMethod, Headers } from '@angular/http';
+import { Injectable } from '@angular/core';
+import { HttpClient, HttpHeaders, HttpErrorResponse } from "@angular/common/http";
 import { IConfiguration }   from '../models/configuration.model';
 import { StorageService }   from './storage.service';
 
@@ -13,14 +13,14 @@ export class ConfigurationService {
     settingsLoaded$ = this.settingsLoadedSource.asObservable();
     isReady: boolean = false;
 
-    constructor(private http: Http, private storageService: StorageService) { }
+    constructor(private http: HttpClient, private storageService: StorageService) { }
 
     load() {
         const baseURI = document.baseURI.endsWith('/') ? document.baseURI : `${document.baseURI}/`;
         let url = `${baseURI}Home/Configuration`;
-        this.http.get(url).subscribe((response: Response) => {
+        this.http.get(url).subscribe((response) => {
             console.log('server settings loaded');
-            this.serverSettings = response.json();
+            this.serverSettings = response as IConfiguration;
             console.log(this.serverSettings);
             this.storageService.store('identityUrl', this.serverSettings.identityUrl);
             this.storageService.store('marketingUrl', this.serverSettings.marketingUrl);

src/Web/WebSPA/Client/modules/orders/orders.service.ts

@@ -14,13 +14,9 @@ export class DataService {
     constructor(private http: HttpClient, private securityService: SecurityService) { }
 
     get(url: string, params?: any): Observable<Response> {
-        let options = {};
-
-        if (this.securityService) {
-            options["headers"] = new HttpHeaders();
-            options["headers"].append('Authorization', 'Bearer ' + this.securityService.GetToken());
-        }
-
+        let options = { };
+        this.setHeaders(options);
+        
         return this.http.get(url, options)
             .pipe(
                 // retry(3), // retry a failed request up to 3 times
@@ -44,16 +40,8 @@ export class DataService {
     }
 
     private doPost(url: string, data: any, needId: boolean, params?: any): Observable<Response> {
-        let options = {};
-
-        options["headers"] = new HttpHeaders();
-        if (this.securityService) {
-            options["headers"].append('Authorization', 'Bearer ' + this.securityService.GetToken());
-        }
-        if (needId) {
-            let guid = Guid.newGuid();
-            options["headers"].append('x-requestid', guid);
-        }
+        let options = { };
+        this.setHeaders(options, needId);
 
         return this.http.post(url, data, options)
             .pipe(
@@ -63,35 +51,10 @@ export class DataService {
                 catchError(this.handleError)
             );
     }
-
-    private doPut(url: string, data: any, needId: boolean, params?: any): Observable<Response> {
-        let options = {};
-
-        options["headers"] = new HttpHeaders();
-        if (this.securityService) {
-            options["headers"].append('Authorization', 'Bearer ' + this.securityService.GetToken());
-        }
-        if (needId) {
-            let guid = Guid.newGuid();
-            options["headers"].append('x-requestid', guid);
-        }
-
-        return this.http.put(url, data, options)
-            .pipe(
-                map((res: Response) => {
-                    return res;
-                }),
-                catchError(this.handleError)
-            );
-    }
-
+    
     delete(url: string, params?: any) {
-        let options = {};
-
-        if (this.securityService) {
-            options["headers"] = new HttpHeaders();
-            options["headers"].append('Authorization', 'Bearer ' + this.securityService.GetToken());
-        }
+        let options = { };
+        this.setHeaders(options);
 
         console.log('data.service deleting');
 
@@ -103,17 +66,42 @@ export class DataService {
     private handleError(error: any) {
         if (error.error instanceof ErrorEvent) {
             // A client-side or network error occurred. Handle it accordingly.
-            console.error('Client side network error occurred:', error.message);
+            console.error('Client side network error occurred:', error.error.message);
         } else {
             // The backend returned an unsuccessful response code.
             // The response body may contain clues as to what went wrong,
             console.error('Backend - ' +
                 `status: ${error.status}, ` +
                 `statusText: ${error.statusText}, ` +
-                `message: ${error.message}`);
+                `message: ${error.error.message}`);
         }
 
         // return an observable with a user-facing error message
         return throwError(error || 'server error');
     }
+
+    private doPut(url: string, data: any, needId: boolean, params?: any): Observable<Response> {
+        let options = { };
+        this.setHeaders(options, needId);
+       
+        return this.http.put(url, data, options)
+            .pipe(
+                map((res: Response) => {
+                    return res;
+                }),
+                catchError(this.handleError)
+            );
+    }
+
+    private setHeaders(options: any, needId?: boolean){
+        if (needId && this.securityService) {            
+            options["headers"] = new HttpHeaders()
+                .append('authorization', 'Bearer ' + this.securityService.GetToken())
+                .append('x-requestid', Guid.newGuid());
+        }
+        else if (this.securityService) {            
+            options["headers"] = new HttpHeaders()
+                .append('authorization', 'Bearer ' + this.securityService.GetToken());
+        }
+    }
 }

src/Web/WebSPA/Client/modules/shared/services/configuration.service.ts

@@ -175,9 +175,7 @@
   </ItemGroup>
 
   <ProjectExtensions>
-    <VisualStudio>
-      <UserProperties package-lock_1json__JSONSchema="http://json.schemastore.org/bower" />
-    </VisualStudio>
+    <VisualStudio><UserProperties package-lock_1json__JSONSchema="http://json.schemastore.org/bower" package_1json__JSONSchema="http://json.schemastore.org/project-1.0.0-beta4" /></VisualStudio>
   </ProjectExtensions>
 
 </Project>