Skip to content

Commit 45677a2

Browse files
committed
react to feedback
1 parent 5339aab commit 45677a2

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

aspnetcore/log-mon/metrics/built-in/includes/built-in10.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -248,9 +248,7 @@ The `Microsoft.AspNetCore.Server.Kestrel` metrics report HTTP connection informa
248248

249249
As this metric is tracking the connection duration, and ideally http connections are used for multiple requests, the buckets should be longer than those used for request durations. For example, using [ 0.01, 0.02, 0.05, 0.1, 0.2, 0.5, 1, 2, 5, 10, 30, 60, 120, 300] provides an upper bucket of 5 mins.
250250

251-
Starting in .NET 9, when a connection ends with a known error, the `error.type` attribute value is set to the known error type. Known connection errors can be found at [Semantic Conventions for Kestrel web server metrics](https://opentelemetry.io/docs/specs/semconv/dotnet/dotnet-kestrel-metrics/).
252-
253-
251+
When a connection ends with a known error, the `error.type` attribute value is set to the known error type. Known connection errors can be found at [Semantic Conventions for Kestrel web server metrics](https://opentelemetry.io/docs/specs/semconv/dotnet/dotnet-kestrel-metrics/).
254252

255253
#### Metric: `kestrel.rejected_connections`
256254

aspnetcore/log-mon/metrics/built-in/includes/built-in8.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,15 @@ The `Microsoft.AspNetCore.Server.Kestrel` metrics report HTTP connection informa
228228

229229
As this metric is tracking the connection duration, and ideally http connections are used for multiple requests, the buckets should be longer than those used for request durations. For example, using [ 0.01, 0.02, 0.05, 0.1, 0.2, 0.5, 1, 2, 5, 10, 30, 60, 120, 300] provides an upper bucket of 5 mins.
230230

231-
Starting in .NET 9, when a connection ends with a known error, the `error.type` attribute value is set to the known error type. Known connection errors can be found at [Semantic Conventions for Kestrel web server metrics](https://opentelemetry.io/docs/specs/semconv/dotnet/dotnet-kestrel-metrics/).
231+
:::moniker-end
232+
233+
:::moniker range="= aspnetcore-9.0"
234+
235+
When a connection ends with a known error, the `error.type` attribute value is set to the known error type. Known connection errors can be found at [Semantic Conventions for Kestrel web server metrics](https://opentelemetry.io/docs/specs/semconv/dotnet/dotnet-kestrel-metrics/).
236+
237+
:::moniker-end
238+
239+
:::moniker range=">= aspnetcore-8.0 < aspnetcore-10.0"
232240

233241
##### Metric: `kestrel.rejected_connections`
234242

0 commit comments

Comments
 (0)