Skip to content

Commit 88eb2bb

Browse files
authored
Apply suggestions from code review
1 parent e5c20e6 commit 88eb2bb

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

aspnetcore/security/app-secrets.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,9 @@ The `Movies:ConnectionString` and `Movies:ServiceApiKey` secrets are mapped to t
202202

203203
## String replacement with secrets
204204

205-
Storing passwords in plain text is insecure. For example, a database connection string stored in `appsettings.json` should not include a password. Instead, store the password as a secret, and include the password in the connection string at runtime. For example:
205+
Storing passwords in plain text is insecure. Never store secrets in a configuration file such as `appsettings.json`, which might get checked in to a source code repository.
206+
207+
For example, a database connection string stored in `appsettings.json` should not include a password. Instead, store the password as a secret, and include the password in the connection string at runtime. For example:
206208

207209
```dotnetcli
208210
dotnet user-secrets set "DbPassword" "`<secret value>`"

aspnetcore/security/app-secrets/includes/app-secrets-3-5.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,9 @@ The `Movies:ConnectionString` and `Movies:ServiceApiKey` secrets are mapped to t
173173

174174
## String replacement with secrets
175175

176-
Storing passwords in plain text is insecure. For example, a database connection string stored in `appsettings.json` should not include a password. Instead, store the password as a secret, and include the password in the connection string at runtime. For example:
176+
Storing passwords in plain text is insecure. Never store secrets in a configuration file such as `appsettings.json`, which might get checked in to a source code repository.
177+
178+
For example, a database connection string stored in `appsettings.json` should not include a password. Instead, store the password as a secret, and include the password in the connection string at runtime. For example:
177179

178180
```dotnetcli
179181
dotnet user-secrets set "DbPassword" "<secret value>"

0 commit comments

Comments
 (0)