Code Example Clarification

[mr5z]

Description

In one of the code example:

public class TokenHandler(IHttpContextAccessor httpContextAccessor) : 
    DelegatingHandler
{
    protected override async Task<HttpResponseMessage> SendAsync(
        HttpRequestMessage request, CancellationToken cancellationToken)
    {
        var accessToken = httpContextAccessor.HttpContext?
            .GetTokenAsync("access_token").Result ?? 
            throw new Exception("No access token");

        request.Headers.Authorization =
            new AuthenticationHeaderValue("Bearer", accessToken);

        return await base.SendAsync(request, cancellationToken);
    }
}

Why do you guys recommend to access .Result instead of awaiting the Task?

I know many developers often copy and paste code without much thought, and their project might have become another victim of that pattern, unless it was intentional.

Page URL

https://learn.microsoft.com/en-us/aspnet/core/blazor/security/blazor-web-app-with-oidc?view=aspnetcore-9.0&pivots=non-bff-pattern-server&source=docs

Content source URL

https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/blazor/security/blazor-web-app-with-oidc.md

Document ID

c3346d3a-346b-8db4-2650-ec044b3f0dd9

Platform Id

1dd51a4e-f734-569f-f6e9-19a27bcd9f4d

Article author

@guardrex

Metadata

• ID: c3346d3a-346b-8db4-2650-ec044b3f0dd9
• PlatformId: 1dd51a4e-f734-569f-f6e9-19a27bcd9f4d
• Service: aspnet-core
• Sub-service: blazor

Related Issues

[github-actions]

🌱🐇 Spring is here!! 🐣🌻

Stand-by! ... A green dinosaur 🦖 will be along shortly to assist.

[guardrex]

Hi @mr5z ... Yes, await the task. This mistake was fixed in most places in an earlier PR. One got by me! 😈 I'll fix it up right now. Thanks for the report.