-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Prefer xref over code-style #33853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer xref over code-style #33853
Conversation
tdykstra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I mention one optional format.
|
@tdykstra @captainsafia I've switched the links to use a style like Tom suggested, but I had added one more stylistic twist. In cases where the link was to an attribute and was followed by "attribute", I moved "attribute" inside the link text. Likewise for "extension method". Here's a snip that shows how this looks now: I don't have strong feelings about this but it seems worth trying. Let me know if you like it better the other way and I can easily change it. |
I don't either, so I'd be interested in getting input from @captainsafia and @Rick-Anderson |
|
@captainsafia convinced me that we should not put "attribute" or "extension method" inside the link text, so I just pushed another commit that reverts that stylistic twist. I think this is good to go now. @captainsafia can you please give it a quick review & approval and then I will merge. |
|
@mikekistler ... Please squash your PRs when merging. |
|
@guardrex Apologies -- I will try to remember to do this next time. |
|
No worries ... just keeping the history tidy 😄 . |

This PR converts code-style references to .NET classes to xref references.
Prior to this there was a mix of code-style and xref references in this file.
Internal previews