Feature static asset deliver /2 #34055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guardrex
approved these changes
Nov 7, 2024
Collaborator
guardrex
left a comment
guardrex
left a comment
There was a problem hiding this comment.
I just have a super NIT on one line.
tdykstra
approved these changes
Nov 7, 2024
Contributor
tdykstra
left a comment
tdykstra
left a comment
There was a problem hiding this comment.
Looks good, I left a couple suggestions
Co-authored-by: Tom Dykstra <[email protected]> Co-authored-by: Luke Latham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34033
Internal previews