Skip to content

Conversation

@guardrex
Copy link
Collaborator

@guardrex guardrex commented Nov 7, 2024

Fixes #34060

BTW @Rick-Anderson @wadepickett @tdykstra ...

I'm finding just a few NIT problems in the Blazor node for reference source links. For example, the release/7.0 branch was dropped, but those assets can be obtained via the v7.0.0 tag (Tags tab of Switch branches or tags).

When I search the whole repo, I see a number of remarks tied to reference source links that are pegged to old framework versions. I'm not performing an analysis on them, so perhaps they're fine, but it seems like a concern. For example, making a current-release remark about API but linking all the way back to the 3.1 or 6.0 reference source 😨. Idk if you want to open an issue to investigate ref source cross-linking.

The Blazor docs will be resolved with my work this morning. I found links with release/3.1, release/5.0, release/6.0, release/7.0, and release/8.0. However, I noticed near the end of my work that I could just get away with searching release/. It brings up a couple of dozen unrelated results, but it's quicker to just skim past them than make all of those separate searches. Too late for me 😄, but it might save you some ⌚.


Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/components/prerendering-and-integration.md aspnetcore/blazor/components/prerendering-and-integration
aspnetcore/blazor/javascript-interoperability/call-dotnet-from-javascript.md aspnetcore/blazor/javascript-interoperability/call-dotnet-from-javascript
aspnetcore/blazor/javascript-interoperability/call-javascript-from-dotnet.md aspnetcore/blazor/javascript-interoperability/call-javascript-from-dotnet
aspnetcore/blazor/progressive-web-app.md aspnetcore/blazor/progressive-web-app

@guardrex guardrex merged commit db9b85a into main Nov 7, 2024
3 checks passed
@guardrex guardrex deleted the guardrex/blazor-remove-70-crosslinks branch November 7, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Blazor ref source cross-links

2 participants