From f6bb61b607b694d8abebf03f61fe8b7f1d3e117a Mon Sep 17 00:00:00 2001 From: Bill Wagner Date: Thu, 7 Nov 2024 10:47:43 -0500 Subject: [PATCH 1/2] Add breaking changes docs Fixes #33996 Add the configuration and TOC changes for publishing the breaking changes articles to the razor compiler. --- .openpublishing.publish.config.json | 7 +++++++ aspnetcore/docfx.json | 24 ++++++++++++++++++++++-- aspnetcore/toc.yml | 4 ++++ 3 files changed, 33 insertions(+), 2 deletions(-) diff --git a/.openpublishing.publish.config.json b/.openpublishing.publish.config.json index 0c550a2f748f..c3538c62f033 100644 --- a/.openpublishing.publish.config.json +++ b/.openpublishing.publish.config.json @@ -63,6 +63,13 @@ "url": "https://github.com/dotnet/AspNetCore.Docs.Samples", "branch": "main", "branch_mapping": {} + }, + { + "path_to_root": "_razor", + "url": "https://github.com/dotnet/razor", + "branch": "main", + "include_in_build": true, + "branch_mapping": {} } ], "branch_target_mapping": { diff --git a/aspnetcore/docfx.json b/aspnetcore/docfx.json index 104f10fa3449..26bda4ef4dd0 100644 --- a/aspnetcore/docfx.json +++ b/aspnetcore/docfx.json @@ -6,6 +6,16 @@ "exclude": [ "**/includes/**", "***/license.md", "**/obj/**", "***/readme.md", "**/sample/**", "**/samples/**", "_site/**" ], "group": "group1", "src": "." + }, + { + "files": [ + "Compiler Breaking Changes - DotNet 8.md", + "Compiler Breaking Changes - DotNet 9.md" + ], + "exclude": [], + "group": "group1", + "src": "../_razor/docs", + "dest": "_razor/docs" } ], "resource": [ @@ -41,10 +51,12 @@ }, "fileMetadata": { "author": { - "whats-new/**/**.md": "rick-anderson" + "whats-new/**/**.md": "rick-anderson", + "_razor/docs/*.md": "rick-anderson" }, "ms.author": { - "whats-new/**/**.md": "riande" + "whats-new/**/**.md": "riande", + "../_razor/docs/*.md": "riande" }, "ms.subservice": { "introduction-to-aspnet-core.md": "index-page", @@ -82,6 +94,14 @@ }, "recommendations": { "**/tutorials/**/**.md": "false" + }, + "title": { + "../_razor/docs/Compiler Breaking Changes - DotNet 8.md": "Razor compiler breaking changes since .NET 8", + "_razor/docs/Compiler Breaking Changes - DotNet 9.md": "Razor compiler breaking changes since .NET 9" + }, + "description": { + "../_razor/docs/Compiler Breaking Changes - DotNet 8.md": "Learn about any breaking changes since the initial release of .NET 8", + "_razor/docs/Compiler Breaking Changes - DotNet 9.md": "Learn about any breaking changes since the initial release of .NET 9" } }, "template": [], diff --git a/aspnetcore/toc.yml b/aspnetcore/toc.yml index 5fbd7dd81c1b..a11c36f76d3d 100644 --- a/aspnetcore/toc.yml +++ b/aspnetcore/toc.yml @@ -797,6 +797,10 @@ items: uid: mvc/controllers/filters - name: Razor SDK uid: razor-pages/sdk + - name: Razor breaking changes since .NET 8 + href: ../_razor/docs/Compiler%20Breaking%20Changes%20-%20DotNet%208.md + - name: Razor breaking changes since .NET 9 + href: ../_razor/docs/Compiler%20Breaking%20Changes%20-%20DotNet%209.md - name: View components uid: mvc/views/view-components - name: View compilation From 774aed08f39a9ba4ef1c586b1ba4ba68f0d2fe0f Mon Sep 17 00:00:00 2001 From: Bill Wagner Date: Tue, 12 Nov 2024 09:48:15 -0500 Subject: [PATCH 2/2] Remove non-functioning attributes The file based meta data isn't working with this folder layout. So, add the metadata to the files directly See dotnet/razor#11199 --- aspnetcore/docfx.json | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/aspnetcore/docfx.json b/aspnetcore/docfx.json index 26bda4ef4dd0..3e95368880c8 100644 --- a/aspnetcore/docfx.json +++ b/aspnetcore/docfx.json @@ -51,12 +51,10 @@ }, "fileMetadata": { "author": { - "whats-new/**/**.md": "rick-anderson", - "_razor/docs/*.md": "rick-anderson" + "whats-new/**/**.md": "rick-anderson" }, "ms.author": { - "whats-new/**/**.md": "riande", - "../_razor/docs/*.md": "riande" + "whats-new/**/**.md": "riande" }, "ms.subservice": { "introduction-to-aspnet-core.md": "index-page", @@ -94,14 +92,6 @@ }, "recommendations": { "**/tutorials/**/**.md": "false" - }, - "title": { - "../_razor/docs/Compiler Breaking Changes - DotNet 8.md": "Razor compiler breaking changes since .NET 8", - "_razor/docs/Compiler Breaking Changes - DotNet 9.md": "Razor compiler breaking changes since .NET 9" - }, - "description": { - "../_razor/docs/Compiler Breaking Changes - DotNet 8.md": "Learn about any breaking changes since the initial release of .NET 8", - "_razor/docs/Compiler Breaking Changes - DotNet 9.md": "Learn about any breaking changes since the initial release of .NET 9" } }, "template": [],