Skip to content

Conversation

@guardrex
Copy link
Collaborator

@guardrex guardrex commented Nov 15, 2024

Fixes #34134

@hakenr ... See what you think of these "improvements" ... "improvements" in quotes because I might be making it worse! 😆


Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/security/server/index.md aspnetcore/blazor/security/server/index

@guardrex guardrex self-assigned this Nov 15, 2024
@hakenr
Copy link
Member

hakenr commented Nov 15, 2024

@guardrex This doesn't align with my understanding of how scoped services work in Blazor. Give me a few minutes to run some tests.

@guardrex
Copy link
Collaborator Author

Sure thing. This came from the PU, so we'll get one of them on here. I may have misinterpreted their supplied remarks/content. I'll also go find the original source of this and cross-link it here. I'll do that after I finish the 9.0 movie tutorial updates. 🏃‍♂️

@guardrex
Copy link
Collaborator Author

Looking better.

Do you still have a concern about the overall approach? I'd rather not ping an engineer unless you have a general concern because they're still super busy with post-9.0 release work. This guidance came from them, so I assume that the overall approach/scenario is valid.

Copy link
Member

@hakenr hakenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@guardrex guardrex merged commit 26ca3e0 into main Nov 15, 2024
3 checks passed
@guardrex guardrex deleted the guardrex-patch-5 branch November 15, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve article section

3 participants