Skip to content

Conversation

@Rick-Anderson
Copy link
Contributor

@Rick-Anderson Rick-Anderson commented Dec 2, 2024

Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion.

## Multiple browser tabs and the Synchronizer Token Pattern

With the Synchronizer Token Pattern, only the most recently loaded page contains a valid antiforgery token. Using multiple tabs can be problematic. For example, if a user opens multiple tabs:
With the Synchronizer Token Pattern, only the most recently loaded page is guaranteed to contain a valid antiforgery token. Apps that wish to support multiple tabs should test supported browsers and log failures. ***Using multiple tabs can be problematic***. For example, if a user opens multiple tabs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intro to the bulleted list is now out of sync with the list itself:

  • is guaranteed to contain
  • contains

Consider changing the second bullet with something similar, like "might fail with an error"

Suggestion that you can accept if you want is in the next comment

@Rick-Anderson Rick-Anderson enabled auto-merge (squash) December 4, 2024 20:45
@Rick-Anderson Rick-Anderson merged commit 393d676 into main Dec 4, 2024
3 checks passed
@Rick-Anderson Rick-Anderson deleted the Rick-Anderson-patch-11 branch December 4, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify antiforgery protection behavior around multiple tabs being open

3 participants