Skip to content

Update anti-request-forgery.md #34257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rick-Anderson merged 5 commits into from
Dec 4, 2024
Merged

Update anti-request-forgery.md #34257

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
59ed84e
Update anti-request-forgery.md
Rick-Anderson Dec 2, 2024
a8d30c8
Update aspnetcore/security/anti-request-forgery.md
Rick-Anderson Dec 4, 2024
9469b1e
Update aspnetcore/security/anti-request-forgery.md
Rick-Anderson Dec 4, 2024
2f04d65
Update aspnetcore/security/anti-request-forgery.md
Rick-Anderson Dec 4, 2024
7f1460b
Update anti-request-forgery.md
Rick-Anderson Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aspnetcore/security/anti-request-forgery.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ Calling <xref:Microsoft.Extensions.DependencyInjection.MvcServiceCollectionExten

## Multiple browser tabs and the Synchronizer Token Pattern

With the Synchronizer Token Pattern, only the most recently loaded page contains a valid antiforgery token. Using multiple tabs can be problematic. For example, if a user opens multiple tabs:
With the Synchronizer Token Pattern, only the most recently loaded page is guaranteed to contain a valid antiforgery token. Apps that wish to support multiple tabs should test supported browsers and log failures. ***Using multiple tabs can be problematic***. For example, if a user opens multiple tabs:
Copy link
Contributor

@tdykstra tdykstra Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intro to the bulleted list is now out of sync with the list itself:

  • is guaranteed to contain
  • contains

Consider changing the second bullet with something similar, like "might fail with an error"

Suggestion that you can accept if you want is in the next comment


* Only the most recently loaded tab contains a valid antiforgery token.
* Requests made from previously loaded tabs fail with an error: `Antiforgery token validation failed. The antiforgery cookie token and request token do not match`
Expand Down
Loading