Add AOT /1 #34320
Merged
Add AOT /1 #34320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rick-Anderson
commented
Dec 9, 2024
Comment on lines
5
to
9
| if (Assembly.GetEntryAssembly()?.GetName().Name != "GetDocument.Insider") | ||
| { | ||
| // 'IServiceCollection' does not contain a definition for 'AddDefaults' | ||
| // builder.Services.AddDefaults(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
@mikekistler AddDefaults doesn't compile. Can you explain the naming conventions?
I don't understand how this code restricts code paths. I'd like the sample to restrict a config and a DB code path. I can add DB init code.
tdykstra
approved these changes
Dec 9, 2024
Contributor
tdykstra
left a comment
tdykstra
left a comment
There was a problem hiding this comment.
LGTM, just some nit suggestions.
mikekistler
reviewed
Dec 10, 2024
aspnetcore/fundamentals/openapi/samples/9.x/GetDocument.Insider/Program.cs
Outdated
Show resolved
Hide resolved
…r/Program.cs Co-authored-by: Mike Kistler <[email protected]>
Rick-Anderson
commented
Dec 10, 2024
aspnetcore/fundamentals/openapi/samples/9.x/GetDocument.Insider/Program.cs
Show resolved
Hide resolved
Rick-Anderson
commented
Dec 11, 2024
| }) | ||
| .WithName("TestKey"); | ||
|
|
||
| app.Run(); |
Contributor
Author
There was a problem hiding this comment.
@mikekistler please approve this code or suggest changes. Once you approve, I'll remove all the other project files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33456
Fixes #34321
Fixes #34342
@mikekistler to reviewInternal previews