Improve Blazor environment guidance #34394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34392
Thanks @nicholasyin! 🚀 ... This improves the guidance with WASM and the environment variable for local development runs. I also include some new guidance for Nginx and Apache file server hosting scenarios. I'm waiting for the product unit to get back to me; but if I don't hear from them by EOD, I'll probably go ahead and merge this. I'll patch it later based on my discussion with them. Thanks for writing in on this, and keep your 👁️ on dotnet/aspnetcore#59456 for some possible improved control in a future release of Blazor.
UPDATE: I just heard back that they're too busy to look right now. I'll make a final pass on Thursday morning. Since this matches the behavior of the framework, I'll go ahead and merge it tomorrow morning. I'll patch it later if anything comes up.
Internal previews