Skip to content

include AOT support in v9 moniker #34613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rick-Anderson merged 2 commits into from
Feb 3, 2025
Merged

include AOT support in v9 moniker #34613

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5ead13
include AOT support in v9 moniker
timdeschryver Jan 31, 2025
218aa5e
fix link
timdeschryver Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions aspnetcore/fundamentals/openapi/aspnetcore-openapi.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,9 +227,7 @@ In order to restrict these code paths from being invoked by the build-time gener

:::code language="csharp" source="~/fundamentals/openapi/samples/9.x/AspireApp1/AspireApp1.Web/Program.cs" highlight="5-8":::

<!--keep-->[AddServiceDefaults](https://source.dot.net/#TestingAppHost1.ServiceDefaults/Extensions.cs,0f0d863053754768,references) Adds common .NET Aspire services such as service discovery, resilience, health checks, and OpenTelemetry.

:::moniker-end
[AddServiceDefaults](https://source.dot.net/#TestingAppHost1.ServiceDefaults/Extensions.cs,0f0d863053754768,references)<!--keep--> adds common .NET Aspire services such as service discovery, resilience, health checks, and OpenTelemetry.
Copy link
Contributor Author

@timdeschryver timdeschryver Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, I noticed a mall formatted link at https://learn.microsoft.com/en-us/aspnet/core/fundamentals/openapi/aspnetcore-openapi?view=aspnetcore-9.0&tabs=visual-studio#customizing-run-time-behavior-during-build-time-document-generation.

image

Due to <!--keep-->, the links is not detected. AFAIK this happens because the comment is the first word on this line. That's why I moved the keep comment after the link.
This change shouldn't interfere with #34489.

cc @Rick-Anderson


## Trimming and Native AOT

Expand Down Expand Up @@ -263,4 +261,6 @@ Publish the app.
dotnet publish
```

:::moniker-end

[!INCLUDE[](~/fundamentals/openapi/includes/aspnetcore-openapi6-8.md)]