Skip to content

Conversation

@tdykstra
Copy link
Contributor

@tdykstra tdykstra commented Feb 3, 2025

Fixes #34607
Fixes #33729
Fixes #32668


Internal previews

📄 File 🔗 Preview link
aspnetcore/test/http-files.md Use .http files in Visual Studio 2022

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (3)

aspnetcore/test/http-files.md:226

  • The JSONPath expression should use '$.token' instead of 'token'.
{{login.response.body.$.token}}

aspnetcore/test/http-files.md:230

  • The XPath expression should use '/token' instead of './token'.
{{login.response.body./token}}

aspnetcore/test/http-files.md:243

  • There is a missing space after '#@name'. It should be '# @name login'.
#@name login

Content-Type: application/json
{
"username": "{{myusername}}",
Copy link

Copilot AI Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a missing comma after '"username": "{{myusername}}"'.

Suggested change
"username": "{{myusername}}",
"username": "{{myusername}}"

Copilot uses AI. Check for mistakes.
@tdykstra tdykstra marked this pull request as ready for review February 3, 2025 22:59
@tdykstra tdykstra merged commit 27c00c8 into dotnet:main Feb 4, 2025
3 checks passed
@tdykstra tdykstra deleted the requestvariables branch February 4, 2025 04:46
@sayedihashimi
Copy link
Member

Sorry for the delay, I reviewed the changes and they look good. Thanks a lot for putting this together. I'm working on a post for the VS blog as well. I'll link to the doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants