-
Notifications
You must be signed in to change notification settings - Fork 25.1k
HybridCache - additional guidance on cache key composition #34644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
also, thoughts on whether any of this should be echoed to (for example) HybridCache.GetOrCreateAsync - and if so: how? This is generated from intellisense - maybe a remarks link along the lines of /// <remarks>For guidance on <paramref name="key"/> usage, please see https://learn.microsoft.com/aspnet/core/performance/caching/hybrid#somesectionhere.</remarks>or is that too clumsy? is there a better / more typical approach? |
tdykstra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great addition to the article! I framed my edits as suggestions that you can accept as-is or edit.
It is both reasonable and welcomed. The information is worth adding to the article. |
I think that makes sense, but I'll ask the expert -- @gewarren How would you handle this:
|
|
@tdykstra I would say option C...both! And there's a clean way to do it, like this: https://github.com/dotnet/dotnet-api-docs/blob/329ae1e7f5f755d8a54fb7da57ef3e0e2ad2844d/xml/System/Func%601.xml#L129 |
Co-authored-by: Tom Dykstra <[email protected]>
Co-authored-by: Tom Dykstra <[email protected]>
Co-authored-by: Tom Dykstra <[email protected]>
Co-authored-by: Tom Dykstra <[email protected]>
Co-authored-by: Tom Dykstra <[email protected]>
Additional clarifications on cache key usage, requested via internal API review
/cc @tdykstra in particular; is this reasonable and welcomed?
Fixes #34647
Internal previews