Skip to content

Conversation

@Rick-Anderson
Copy link
Contributor

@Rick-Anderson Rick-Anderson commented Apr 1, 2025

Moves the built-in metrics ref page from the dotnet/docs repo to the dotnet/AspNetCore.Docs repo.

Contributes to #35109 and dotnet/docs#45580
Prepares for dotnet/docs#45379

Copy/paste of https://github.com/dotnet/docs/blob/main/docs/core/diagnostics/built-in-metrics-aspnetcore.md and:

  • Deletes all the available in .NET 8 disclaimers as this is now handled by monikers.
  • changes meta-data

Internal previews

📄 File 🔗 Preview link
aspnetcore/log-mon/metrics/built-in.md aspnetcore/log-mon/metrics/built-in
aspnetcore/toc.yml aspnetcore/toc

@Rick-Anderson Rick-Anderson requested a review from gewarren April 1, 2025 20:05
@Rick-Anderson
Copy link
Contributor Author

@gewarren can I merge this? It's a copy/paste with only a few changes. I need to add the new .NET 10 metrics in the next PR.

@gewarren
Copy link
Contributor

gewarren commented Apr 2, 2025

@gewarren can I merge this? It's a copy/paste with only a few changes. I need to add the new .NET 10 metrics in the next PR.

It's fine with me, but are @noahfalk and/or @JamesNK okay with moving them here?

@Rick-Anderson
Copy link
Contributor Author

cc @MackinnonBuck

@noahfalk
Copy link
Member

noahfalk commented Apr 2, 2025

It's fine with me, but are @noahfalk and/or @JamesNK okay with moving them here?

I'm fine with it but can't speak for James.

@Rick-Anderson Rick-Anderson merged commit a055d97 into main Apr 3, 2025
3 checks passed
@Rick-Anderson Rick-Anderson deleted the metrics/move branch April 3, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants