Skip to content

Conversation

@wadepickett
Copy link
Contributor

@wadepickett wadepickett commented Apr 9, 2025

Per this comment in #34948

Contributes to #34948


Internal previews

📄 File 🔗 Preview link
aspnetcore/release-notes/aspnetcore-10.0.md aspnetcore/release-notes/aspnetcore-10.0

@wadepickett wadepickett self-assigned this Apr 9, 2025
@wadepickett wadepickett requested a review from mikekistler April 9, 2025 17:36
@wadepickett
Copy link
Contributor Author

wadepickett commented Apr 9, 2025

@mikekistler, need your review on this edit pass on Validation Support for Minimal API. Did I include all that was intended for this subject for the What's New?

@wadepickett wadepickett marked this pull request as ready for review April 9, 2025 17:37
Copy link
Contributor

@Rick-Anderson Rick-Anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove newlines an future case

Copy link
Contributor

@Rick-Anderson Rick-Anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove newlines and future tense

Comment on lines 17 to 18
If validation fails, the runtime returns a 400 Bad Request response with
details of the validation errors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these newlines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rick-Anderson, thanks. Which " new lines" are you referring to? Do you mean remove the Query/Header/Request body as a list and the new lines around it? Please be more specific.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you mean new edits, not actual new lines? Sorry, not trying to be pain here, I just really don't know which you are referring to.

Copy link
Contributor

@Rick-Anderson Rick-Anderson Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are lots of new lines
this on on a line
and this is on another line

I've identified several where there is a line break and there shouldn't be a line break.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor Author

@wadepickett wadepickett Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First time you mentioned line break. I didn't know what you were referring to until now. The text wrap I was seeing was right on those, unfortunately. Thanks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't do a final edit, and I was worried about this type of problem. I knew tho that they would be addressed on the next round of edits ... this edit. 😄

BTW... I'm already in 🛌 . It's getting late here. I'll be back online in the morning. I'll be wrapping up the Blazor Pre3 items tomorrow.

@wadepickett
Copy link
Contributor Author

@Rick-Anderson, thanks for catching the line breaks and the future tense. I corrected those and it is ready for review.

@wadepickett wadepickett removed the request for review from guardrex April 10, 2025 01:33
@Rick-Anderson Rick-Anderson merged commit 0a99802 into main Apr 10, 2025
3 checks passed
@Rick-Anderson Rick-Anderson deleted the wadepickett/34948WhatsNew10Prev3ValidationMinAPIpart2 branch April 10, 2025 02:48
wadepickett added a commit that referenced this pull request Apr 10, 2025
* Adds .NET 9 sample to mongo app (#35189)

* copy-paste to 9.x

* update code to .NET 9

* update references to code

* update references to 8.x code

* upate ms date

* add missing snapshot

* Update aspnetcore/tutorials/first-mongo-app.md

---------

Co-authored-by: Wade Pickett <[email protected]>

* SSE return types /2 (#35152)

* SSE return types /2

* SSE return types /2

* SSE return types /2

* SSE return types /2

* SSE return types /2

* fixes

* Update aspnetcore/fundamentals/minimal-apis/responses.md

Co-authored-by: Mike Kistler <[email protected]>

* Apply suggestions from code review

Co-authored-by: Mike Kistler <[email protected]>

* react to feedback

* Update aspnetcore/web-api/action-return-types/samples/10/ControllerSSE/HearRate.cs

Co-authored-by: Mike Kistler <[email protected]>

* react to feedback

---------

Co-authored-by: Mike Kistler <[email protected]>

* Update complex-data-model.md

Fixes #35191

* WN .NET 10 Prev 3: Validation Support Minimal API (#35188)

* WN .NET 10 Prev 3: Validation Support Minimal API

* Added include to What's New topic for .NET 10 Preview 3

* Update with correct links

* Format link for attribute

* Correct DataAnnotations link

* Add review suggestions, remove future tense and lines

* Minor edit

* Remove line breaks

* fixed line break

* [Pre3] Boot config file name change (#35176)

* [Pre3] Declaratively persist state (#35198)

* Blazor Pre3 final updates for release (#35200)

* Patch Blazor Pre3 API (#35201)

---------

Co-authored-by: Tim Deschryver <[email protected]>
Co-authored-by: Wade Pickett <[email protected]>
Co-authored-by: Rick Anderson <[email protected]>
Co-authored-by: Mike Kistler <[email protected]>
Co-authored-by: Luke Latham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants