-
Notifications
You must be signed in to change notification settings - Fork 25.1k
WN .NET 10 Prev 3: Validation Support Minimal API #35188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WN .NET 10 Prev 3: Validation Support Minimal API #35188
Conversation
|
@mikekistler, need your review on this edit pass on Validation Support for Minimal API. Did I include all that was intended for this subject for the What's New? |
Rick-Anderson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove newlines an future case
aspnetcore/release-notes/aspnetcore-10/includes/ValidationSupportMinAPI.md
Outdated
Show resolved
Hide resolved
Rick-Anderson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove newlines and future tense
| If validation fails, the runtime returns a 400 Bad Request response with | ||
| details of the validation errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove these newlines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rick-Anderson, thanks. Which " new lines" are you referring to? Do you mean remove the Query/Header/Request body as a list and the new lines around it? Please be more specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you mean new edits, not actual new lines? Sorry, not trying to be pain here, I just really don't know which you are referring to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are lots of new lines
this on on a line
and this is on another line
I've identified several where there is a line break and there shouldn't be a line break.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First time you mentioned line break. I didn't know what you were referring to until now. The text wrap I was seeing was right on those, unfortunately. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't do a final edit, and I was worried about this type of problem. I knew tho that they would be addressed on the next round of edits ... this edit. 😄
BTW... I'm already in 🛌 . It's getting late here. I'll be back online in the morning. I'll be wrapping up the Blazor Pre3 items tomorrow.
|
@Rick-Anderson, thanks for catching the line breaks and the future tense. I corrected those and it is ready for review. |
* Adds .NET 9 sample to mongo app (#35189) * copy-paste to 9.x * update code to .NET 9 * update references to code * update references to 8.x code * upate ms date * add missing snapshot * Update aspnetcore/tutorials/first-mongo-app.md --------- Co-authored-by: Wade Pickett <[email protected]> * SSE return types /2 (#35152) * SSE return types /2 * SSE return types /2 * SSE return types /2 * SSE return types /2 * SSE return types /2 * fixes * Update aspnetcore/fundamentals/minimal-apis/responses.md Co-authored-by: Mike Kistler <[email protected]> * Apply suggestions from code review Co-authored-by: Mike Kistler <[email protected]> * react to feedback * Update aspnetcore/web-api/action-return-types/samples/10/ControllerSSE/HearRate.cs Co-authored-by: Mike Kistler <[email protected]> * react to feedback --------- Co-authored-by: Mike Kistler <[email protected]> * Update complex-data-model.md Fixes #35191 * WN .NET 10 Prev 3: Validation Support Minimal API (#35188) * WN .NET 10 Prev 3: Validation Support Minimal API * Added include to What's New topic for .NET 10 Preview 3 * Update with correct links * Format link for attribute * Correct DataAnnotations link * Add review suggestions, remove future tense and lines * Minor edit * Remove line breaks * fixed line break * [Pre3] Boot config file name change (#35176) * [Pre3] Declaratively persist state (#35198) * Blazor Pre3 final updates for release (#35200) * Patch Blazor Pre3 API (#35201) --------- Co-authored-by: Tim Deschryver <[email protected]> Co-authored-by: Wade Pickett <[email protected]> Co-authored-by: Rick Anderson <[email protected]> Co-authored-by: Mike Kistler <[email protected]> Co-authored-by: Luke Latham <[email protected]>

Per this comment in #34948
Contributes to #34948
Internal previews