-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Replace .NET Core with .NET naming throughout documentation #35800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: danroth27 <[email protected]>
Co-authored-by: danroth27 <[email protected]>
Co-authored-by: danroth27 <[email protected]>
Co-authored-by: danroth27 <[email protected]>
Co-authored-by: danroth27 <[email protected]>
…tion Co-authored-by: danroth27 <[email protected]>
…tion Co-authored-by: danroth27 <[email protected]>
Co-authored-by: danroth27 <[email protected]>
Co-authored-by: danroth27 <[email protected]>
danroth27
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@danroth27 ... Are you OK??!! Copilot beat the crap out of you! 👦🤛😵😆 This might cause merge conflicts after it goes in, but I see it continued to leave Do you want me to review this? If so, I can look first thing in the morning, as I'm going to bed right now. 🛌💤 |
@guardrex Yes, please! I want to make sure I didn't mess anything up. |
|
Sure thing. Give me a couple of hours. I took a break to lift some weights. 🏋️♂️💪 |
tdykstra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Practically flawless! I just found a few questionable instances.
Co-authored-by: Tom Dykstra <[email protected]>
Co-authored-by: Tom Dykstra <[email protected]>
|
@tdykstra What do I need to do about the build warnings? |
guardrex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a handful of passing super-NITs 😈.
BTW on the build warnings ... The API is still under investigation, and Tom and Wade are going to reassign Rick's stuff soon.
Co-authored-by: Luke Latham <[email protected]>
Co-authored-by: Luke Latham <[email protected]>
Co-authored-by: Luke Latham <[email protected]>
Co-authored-by: Luke Latham <[email protected]>
Co-authored-by: Luke Latham <[email protected]>
|
Looking at the 404 warnings in the build for this PR: The theme seems to be at least partially (if not all) preview 5 & 6 API reference that does not exist yet in the API ref build. There are issues with the build for including 5 and 6 which we are trying to square away with the vendors that handle them right now. They have something like 900 issues in them and are trying to nail down what happened. In addition, there seemed to be problems with a missing package for Identity as part of the Azure SDK API ref which I also raised with the vendors and the PM who manages that area. (Dan, I included you on the cc for that thread today so you can see when it gets resolved) You might have to ignore the 404 warnings as we try to get the API ref build issues figured out. Examples I think of 5&6 preview related API in warnings in this PR: xref:Microsoft.Extensions.Validation.IValidationContext - This is part of the validation APIs that were moved to the Microsoft.Extensions.Validation namespace in .NET 10 Preview 6, making them usable outside ASP.NET Core scenarios. xref:Microsoft.AspNetCore.Builder.MetricsEndpointRouteBuilderExtensions.MapMetrics* - A new metrics endpoint mapping API introduced in .NET 10 Preview 5 for enhanced observability features. xref:Microsoft.Extensions.Hosting.HostingHostBuilderExtensions.ConfigureOpenTelemetry* - Part of the OpenTelemetry integration improvements added in .NET 10 Preview 5. xref:Microsoft.AspNetCore.Components.Web.RenderMode - An updated API in .NET 10 Preview 6 that includes new render mode options for Blazor applications. |
|
I asked Copilot Claud Sonnet 3.7 to run a link to the build report that had the warnings against the actual PR. It had these observations listed below. Some of them are related to preview 5-6 which is not in the API ref yet so makes sense there is a 404, and there are some related to Identity, which the vendor team is also working on since a package seemed to have dropped out, but copilot also made suggestions on the rest, when asked to look for patterns: APIs Introduced in .NET 10 Preview 5: The Remaining xref 404 Warnings: Microsoft.AspNetCore.Mvc namespace - These APIs were introduced in earlier versions of ASP.NET Core (some as early as ASP.NET Core 1.0), but the xref system may be having trouble with them due to the naming changes from .NET Core to .NET that this PR is addressing. Microsoft.AspNetCore.RazorPages namespace - These were introduced in ASP.NET Core 2.0 but may be experiencing reference issues due to the documentation system update. Microsoft.AspNetCore.Builder namespace - Many of the endpoint routing extensions were introduced in ASP.NET Core 3.0 but have been continuously enhanced. Microsoft.AspNetCore.Identity namespace - These APIs have evolved from ASP.NET Core 2.0 through 9.0. File-related errors - The build report shows many missing content files (Status: 404) for various markdown documents in the AspNetCore.Docs repository, which could be caused by file renames or moves in this PR. These xref 404 warnings are occurring primarily because:
|
wadepickett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Also provided summary on what is going on with the build warnings due to API ref missing from the API ref published for Identity and Preview 5-6. Those issues are being handled seperately.
This PR systematically updates the ASP.NET Core documentation to replace references to ".NET Core" with ".NET" to align with the current naming conventions introduced with .NET 5.
Changes Made
Updated 172 files across the documentation to replace standalone ".NET Core" references with ".NET" while carefully preserving all "ASP.NET Core" references unchanged.
Key Areas Updated:
Examples of Changes:
Technical Implementation:
(?<!ASP)\.NET Coreto ensure "ASP.NET Core" references were preservedValidation:
Fixes #35799.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Internal previews
Toggle expand/collapse
Note
This table shows preview links for the 30 files with the most changes. For preview links for other files in this PR, select OpenPublishing.Build Details within checks.