Restore missing code example #35880
Merged
Restore missing code example #35880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restores a missing code example for HTTP logging with redaction by creating a new code snippet file and updating the documentation reference to point to the correct location.
- Adds a new code snippet file (
samples-snapshot/9.x/Program.cs) containing HTTP logging configuration examples - Updates the documentation to reference the correct code snippet file path
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| aspnetcore/fundamentals/http-logging/samples-snapshot/9.x/Program.cs | New file containing HTTP logging configuration code snippets with redaction examples |
| aspnetcore/fundamentals/http-logging/index.md | Updates code snippet reference from samples/9.x/ to samples-snapshot/9.x/ path |
| { | ||
| logging.LoggingFields = HttpLoggingFields.Duration; | ||
| }); | ||
| builder.Services.AddHttpLoggingInterceptor<SampleHttpLoggingInterceptor>(); |
There was a problem hiding this comment.
The code references SampleHttpLoggingInterceptor but this class is not defined or imported. This will cause a compilation error when users try to use this code example.
wadepickett
approved these changes
Aug 4, 2025
Contributor
wadepickett
left a comment
wadepickett
left a comment
There was a problem hiding this comment.
Looks good. Approved. @tdykstra, you might consider updating the ms.date.
| @@ -0,0 +1,12 @@ | |||
| // <snippet7> | |||
| // <snippet4> | |||
| Http logging with redaction can be enabled by calling <xref:Microsoft.Extensions.DependencyInjection.HttpLoggingServiceCollectionExtensions.AddHttpLoggingRedaction%2A>: | ||
|
|
||
| [!code-csharp[](~/fundamentals/http-logging/samples/9.x/Program.cs?name=snippet7&highlight=9)] | ||
| [!code-csharp[](~/fundamentals/http-logging/samples-snapshot/9.x/Program.cs?name=snippet7&highlight=9)] |
Member
There was a problem hiding this comment.
highlight seems to be wrong?
BrennanConroy
approved these changes
Aug 4, 2025
aspnetcore/fundamentals/http-logging/samples-snapshot/9.x/Program.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Brennan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35809
Internal previews