-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Add QuicTransportOptions configuration documentation to HTTP/3 guide #36341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QuicTransportOptions configuration documentation to HTTP/3 guide #36341
Conversation
Co-authored-by: JamesNK <[email protected]>
Co-authored-by: JamesNK <[email protected]>
Co-authored-by: JamesNK <[email protected]>
aspnetcore/fundamentals/servers/kestrel/samples/6.x/KestrelSample/Snippets/Program.cs
Outdated
Show resolved
Hide resolved
aspnetcore/fundamentals/servers/kestrel/samples/6.x/KestrelSample/Snippets/Program.cs
Outdated
Show resolved
Hide resolved
… remove pragma Co-authored-by: JamesNK <[email protected]>
Co-authored-by: JamesNK <[email protected]>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Co-authored-by: JamesNK <[email protected]>
Co-authored-by: JamesNK <[email protected]>
aspnetcore/fundamentals/servers/kestrel/samples/6.x/KestrelSample/Snippets/Program.cs
Outdated
Show resolved
Hide resolved
|
@JamesNK ... Nevermind! It looks like it's actually going to do what I say! 🎉 This is the first time it has ever paid attention to my orders. |
Co-authored-by: guardrex <[email protected]>
|
@copilot There are three remaining suggestions that I made that you didn't commit. Commit the last three suggestions. |
The three suggestions on lines 78, 79, and 83 appear incomplete in the comment thread (showing only |
|
@copilot It looks like you are only assessing these rows by looking at how GitHub is displaying them in the web UI. If you look at the lines in the raw markdown file, you will see that each of my suggestions is for changes to individual lines. You should be assessing the changes by looking at the raw markdown file, not what GitHub displays in this web UI. @copilot Don't commit the final three suggesions. I will commit them myself right now. Stand by and take no further action on my review. |
|
@copilot I made the changes, and my review was complete. I already approved the PR. There was no need for you to request another approval from me after I just approved it. However, I will approve the PR again. @wadepickett @tdykstra ... A T-800 is going to show up at my house first after Skynet takes over! 😆 AI has been helpful for catching small errors when a PR goes up, but OMG on how much I see everyone fighting with it thereafter over the simplest things. It doesn't seem like it's saving all that much 💰 right now. Let's hope it improves quickly. 🤞🍀 |
|
"how much I see everyone fighting with it thereafter over the simplest things. It doesn't seem like it's saving all that much 💰 right now." Yes, still entirely in a training phase for this repo (and others). The messy and at times frustrating stage. You are identifying some great items it is tripping up on. At the moment for every good catch I receive from Copilot there are a series of items it trips on in my expreience too. I’ll be adding a review-specific Copilot instruction set soon for you and Tom to review and add to. As we go along and spot common GitHub Copilot errors in this doc set that can be helped with prompts in that instruction set, we can add to it as we go. We can’t control the model it chooses, and with every model update we may see drastic changes for the better or some things break. It’s a small share of our time, but an important part of my job and Tom’s is to help Copilot be more successful with our content and eventually more usable from the MCP venue for handling top questions through AI interfaces. |
wadepickett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look great with the updates in. Approved.
Documents how to configure
QuicTransportOptionsusing theUseQuicextension method onIWebHostBuilder, addressing the gap in HTTP/3 transport configuration documentation.Changes
New documentation section in
http3.mdcoveringQuicTransportOptionsconfigurationUseQuic(Action<QuicTransportOptions>)extension methodCode sample demonstrating configuration pattern in
Snippets/Program.cs:Properties documented
0x010c/H3_REQUEST_CANCELLED)0x100/H3_NO_ERROR)Code Review Updates
ai-usageto alphabetical position aftertitleMetadata Updates
ms.dateto 11/13/2025ai-usage: ai-assistedmetadata in alphabetical orderOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Internal previews