Fix BenchmarkDotNet test adapter not running tests with dotnet test (#2571)

sheffer21 · web-flow · commit 063d2f0dda0e · 2024-05-19T08:54:48.000-04:00
* fix VsTestAdapter test filtering

* CR fixes
diff --git a/src/BenchmarkDotNet.TestAdapter/BenchmarkExecutor.cs b/src/BenchmarkDotNet.TestAdapter/BenchmarkExecutor.cs
@@ -38,7 +38,7 @@ public void RunBenchmarks(string assemblyPath, TestExecutionRecorderWrapper reco
                 foreach (var benchmarkCase in benchmark.BenchmarksCases)
                 {
                     var testId = benchmarkCase.GetTestCaseId();
-                    if (benchmarkIds != null && benchmarkIds.Contains(testId))
+                    if (benchmarkIds == null || benchmarkIds.Contains(testId))
                     {
                         filteredCases.Add(benchmarkCase);
                         testCases.Add(benchmarkCase.ToVsTestCase(assemblyPath, needsJobInfo));

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ public void RunBenchmarks(string assemblyPath, TestExecutionRecorderWrapper reco`
`38`	`38`	`foreach (var benchmarkCase in benchmark.BenchmarksCases)`
`39`	`39`	`{`
`40`	`40`	`var testId = benchmarkCase.GetTestCaseId();`
`41`		`- if (benchmarkIds != null && benchmarkIds.Contains(testId))`
	`41`	`+ if (benchmarkIds == null \|\| benchmarkIds.Contains(testId))`
`42`	`42`	`{`
`43`	`43`	`filteredCases.Add(benchmarkCase);`
`44`	`44`	`testCases.Add(benchmarkCase.ToVsTestCase(assemblyPath, needsJobInfo));`