Additional diagnostics in WindowsDisassembler (see #1836)

Author: AndreyAkinshin

src/BenchmarkDotNet/Disassemblers/WindowsDisassembler.cs

@@ -31,12 +31,15 @@ public DisassemblyResult Disassemble(DiagnoserActionParameters parameters)
         {
             string resultsPath = Path.GetTempFileName();
 
-            string errors = ProcessHelper.RunAndReadOutput(
-                GetDisassemblerPath(parameters.Process, parameters.BenchmarkCase.Job.Environment.Platform),
-                BuildArguments(parameters, resultsPath));
+            string disassemblerPath = GetDisassemblerPath(parameters.Process, parameters.BenchmarkCase.Job.Environment.Platform);
+            string arguments = BuildArguments(parameters, resultsPath);
+            string errors = ProcessHelper.RunAndReadOutput(disassemblerPath, arguments);
 
             if (!string.IsNullOrEmpty(errors))
+            {
                 parameters.Config.GetCompositeLogger().WriteError(errors);
+                return new DisassemblyResult { Errors = new[] { errors } };
+            }
 
             try
             {
@@ -48,6 +51,10 @@ public DisassemblyResult Disassemble(DiagnoserActionParameters parameters)
                     return (DisassemblyResult)serializer.Deserialize(reader);
                 }
             }
+            catch (Exception e)
+            {
+                throw new Exception($"Can't read disassembly diagnostic file (DisassemblerPath = '{disassemblerPath}', Arguments = '{arguments}')", e);
+            }
             finally
             {
                 File.Delete(resultsPath);
@@ -80,9 +87,9 @@ private static string GetDisassemblerPath(string architectureName)
 
             var dir = new FileInfo(assemblyWithDisassemblersInResources.Location).Directory ?? throw new DirectoryNotFoundException();
             string disassemblerPath = Path.Combine(
-                    dir.FullName,
-                    FolderNameHelper.ToFolderName(BenchmarkDotNetInfo.FullVersion), // possible update
-                    exeName); // separate process per architecture!!
+                dir.FullName,
+                FolderNameHelper.ToFolderName(BenchmarkDotNetInfo.FullVersion), // possible update
+                exeName); // separate process per architecture!!
 
             Path.GetDirectoryName(disassemblerPath).CreateIfNotExists();