handle processes that don't exit on time more gracefully, fixes #1731. (#1745)

Co-authored-by: Adam Sitnik <[email protected]>

Author: cgranade

src/BenchmarkDotNet/Running/BenchmarkRunnerClean.cs

@@ -402,7 +402,14 @@ private static (bool success, List<ExecuteResult> executeResults, GcStats gcStat
 
                 if (executeResult.ProcessId.HasValue)
                 {
-                    logger.WriteLineInfo($"// Benchmark Process {executeResult.ProcessId} has exited with code {executeResult.ExitCode}");
+                    if (executeResult.ExitCode is int exitCode)
+                    {
+                        logger.WriteLineInfo($"// Benchmark Process {executeResult.ProcessId} has exited with code {exitCode}.");
+                    }
+                    else
+                    {
+                        logger.WriteLineInfo($"// Benchmark Process {executeResult.ProcessId} failed to exit.");
+                    }
                 }
 
                 executeResults.Add(executeResult);

src/BenchmarkDotNet/Toolchains/DotNetCli/DotNetCliExecutor.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Diagnostics;
 using System.IO;
+using System.Threading;
 using BenchmarkDotNet.Characteristics;
 using BenchmarkDotNet.Diagnosers;
 using BenchmarkDotNet.Engines;
@@ -21,6 +22,7 @@ public class DotNetCliExecutor : IExecutor
         public DotNetCliExecutor(string customDotNetCliPath) => CustomDotNetCliPath = customDotNetCliPath;
 
         private string CustomDotNetCliPath { get; }
+        private static readonly TimeSpan ProcessExitTimeout = TimeSpan.FromSeconds(2);
 
         public ExecuteResult Execute(ExecuteParameters executeParameters)
         {
@@ -88,15 +90,15 @@ private ExecuteResult Execute(BenchmarkCase benchmarkCase,
 
                 loggerWithDiagnoser.ProcessInput();
 
-                if (!process.WaitForExit(milliseconds: 250))
+                if (!process.WaitForExit(milliseconds: (int)ProcessExitTimeout.TotalMilliseconds))
                 {
-                    logger.WriteLineInfo("// The benchmarking process did not quit on time, it's going to get force killed now.");
+                    logger.WriteLineInfo($"// The benchmarking process did not quit within {ProcessExitTimeout.TotalSeconds} seconds, it's going to get force killed now.");
 
                     consoleExitHandler.KillProcessTree();
                 }
 
-                return new ExecuteResult(true, process.ExitCode, process.Id, loggerWithDiagnoser.LinesWithResults, loggerWithDiagnoser.LinesWithExtraOutput);
+                return new ExecuteResult(true, process.HasExited ? (int?)process.ExitCode : null, process.Id, loggerWithDiagnoser.LinesWithResults, loggerWithDiagnoser.LinesWithExtraOutput);
             }
         }
     }
-}
+}

src/BenchmarkDotNet/Toolchains/Results/ExecuteResult.cs

@@ -5,12 +5,12 @@ namespace BenchmarkDotNet.Toolchains.Results
     public class ExecuteResult
     {
         public bool FoundExecutable { get; }
-        public int ExitCode { get; }
+        public int? ExitCode { get; }
         public int? ProcessId { get; }
         public IReadOnlyList<string> Data { get; }
         public IReadOnlyList<string> ExtraOutput { get; }
 
-        public ExecuteResult(bool foundExecutable, int exitCode, int? processId, IReadOnlyList<string> data, IReadOnlyList<string> linesWithExtraOutput)
+        public ExecuteResult(bool foundExecutable, int? exitCode, int? processId, IReadOnlyList<string> data, IReadOnlyList<string> linesWithExtraOutput)
         {
             FoundExecutable = foundExecutable;
             Data = data;