Skip to content

Commit 2e62b9b

Browse files
Remove netcoreapp2.0;net461 from TFMs for IntegrationTests.ManualRunning.MultipleFrameworks
1 parent 0583cb9 commit 2e62b9b

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

tests/BenchmarkDotNet.IntegrationTests.ManualRunning.MultipleFrameworks/BenchmarkDotNet.IntegrationTests.ManualRunning.MultipleFrameworks.csproj

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,16 @@
44
<AssemblyTitle>BenchmarkDotNet.IntegrationTests.ManualRunning.MultipleFrameworks</AssemblyTitle>
55
<!-- We test the oldest frameworks supported by BDN (net461 and netcoreapp2.0), as well as newer versions of those frameworks. -->
66
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
7-
<TargetFrameworks>net461;net48;netcoreapp2.0;net8.0</TargetFrameworks>
8-
<NoWarn>$(NoWarn);NU1903</NoWarn> <!-- NU1903: Package 'Microsoft.NETCore.App' 2.0.0 has a known high severity vulnerability -->
7+
<!-- Using netcoreapp2.0 and net461 as one of the target frameworks leads to the following problems:-->
8+
<!-- * NU1903: Package 'Microsoft.NETCore.App' 2.0.0 has a known high severity vulnerability -->
9+
<!-- * Incompability with xunit.runner.visualstudio 2.4.2+ -->
10+
<!-- Therefore, we don't use it explicitly in the source code base to avoid persistent warnings -->
11+
<!-- If you need it for local backward compatibility experiments, do the following: -->
12+
<!-- 1. Add 'netcoreapp2.0;net461' in the list of TargetFrameworks -->
13+
<!-- 2. Add '<NoWarn>$(NoWarn);NU1903</NoWarn>' -->
14+
<!-- 3. Downgrade the xunit.runner.visualstudio NuGet package to v2.4.1 -->
15+
<!-- Please, do not commit these changes to the repository -->
16+
<TargetFrameworks>net462;net48;net8.0</TargetFrameworks>
917
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
1018
<AssemblyName>BenchmarkDotNet.IntegrationTests.ManualRunning.MultipleFrameworks</AssemblyName>
1119
<PackageId>BenchmarkDotNet.IntegrationTests.ManualRunning.MultipleFrameworks</PackageId>

0 commit comments

Comments
 (0)