Change DisassemblyDiagnoser to use byte unit always (#1855)

Author: YegorStepanov

src/BenchmarkDotNet/Columns/MetricColumn.cs

@@ -32,6 +32,9 @@ public string GetValue(Summary summary, BenchmarkCase benchmarkCase, SummaryStyl
                 return "-";
 
             var cultureInfo = summary.GetCultureInfo();
+
+            if (style.PrintUnitsInContent && descriptor.UnitType == UnitType.CodeSize)
+                return SizeValue.FromBytes((long)metric.Value).ToString(style.CodeSizeUnit, cultureInfo, descriptor.NumberFormat);
             if (style.PrintUnitsInContent && descriptor.UnitType == UnitType.Size)
                 return SizeValue.FromBytes((long)metric.Value).ToString(style.SizeUnit, cultureInfo, descriptor.NumberFormat);
             if (style.PrintUnitsInContent && descriptor.UnitType == UnitType.Time)

src/BenchmarkDotNet/Columns/UnitType.cs

@@ -4,6 +4,7 @@ public enum UnitType
     {
         Dimensionless,
         Time,
-        Size
+        Size,
+        CodeSize
     }
 }

src/BenchmarkDotNet/Disassemblers/DisassemblyDiagnoser.cs

@@ -165,8 +165,8 @@ private class NativeCodeSizeMetricDescriptor : IMetricDescriptor
             public string Id => "Native Code Size";
             public string DisplayName => "Code Size";
             public string Legend => "Native code size of the disassembled method(s)";
-            public string NumberFormat => "0.##";
-            public UnitType UnitType => UnitType.Size;
+            public string NumberFormat => "N0";
+            public UnitType UnitType => UnitType.CodeSize;
             public string Unit => SizeUnit.B.Name;
             public bool TheGreaterTheBetter => false;
             public int PriorityInCategory => 0;

src/BenchmarkDotNet/Extensions/CommonExtensions.cs

@@ -19,6 +19,8 @@ public static string GetColumnTitle(this IColumn column, SummaryStyle style)
 
             switch (column.UnitType)
             {
+                case UnitType.CodeSize:
+                    return $"{column.ColumnName} [{style.CodeSizeUnit.Name}]";
                 case UnitType.Size:
                     return $"{column.ColumnName} [{style.SizeUnit.Name}]";
                 case UnitType.Time:

src/BenchmarkDotNet/Reports/SummaryStyle.cs

@@ -19,6 +19,7 @@ public class SummaryStyle : IEquatable<SummaryStyle>
         public bool PrintZeroValuesInContent { get; }
         public int MaxParameterColumnWidth { get; }
         public SizeUnit SizeUnit { get; }
+        internal SizeUnit CodeSizeUnit { get; }
         public TimeUnit TimeUnit { get; }
         [NotNull]
         public CultureInfo CultureInfo { get; }
@@ -39,6 +40,7 @@ public SummaryStyle([CanBeNull] CultureInfo cultureInfo, bool printUnitsInHeader
             PrintZeroValuesInContent = printZeroValuesInContent;
             MaxParameterColumnWidth = maxParameterColumnWidth;
             RatioStyle = ratioStyle;
+            CodeSizeUnit = SizeUnit.B;
         }
 
         public SummaryStyle WithTimeUnit(TimeUnit timeUnit)
@@ -70,6 +72,7 @@ public bool Equals(SummaryStyle other)
                    && PrintUnitsInContent == other.PrintUnitsInContent
                    && PrintZeroValuesInContent == other.PrintZeroValuesInContent
                    && Equals(SizeUnit, other.SizeUnit)
+                   && Equals(SizeUnit, other.CodeSizeUnit)
                    && Equals(TimeUnit, other.TimeUnit)
                    && MaxParameterColumnWidth == other.MaxParameterColumnWidth
                    && RatioStyle == other.RatioStyle;
@@ -85,6 +88,7 @@ public override int GetHashCode()
                 hashCode = (hashCode * 397) ^ PrintUnitsInContent.GetHashCode();
                 hashCode = (hashCode * 397) ^ PrintZeroValuesInContent.GetHashCode();
                 hashCode = (hashCode * 397) ^ (SizeUnit != null ? SizeUnit.GetHashCode() : 0);
+                hashCode = (hashCode * 397) ^ (CodeSizeUnit != null ? CodeSizeUnit.GetHashCode() : 0);
                 hashCode = (hashCode * 397) ^ (TimeUnit != null ? TimeUnit.GetHashCode() : 0);
                 hashCode = (hashCode * 397) ^ MaxParameterColumnWidth;
                 hashCode = (hashCode * 397) ^ RatioStyle.GetHashCode();