Fix argument escaping (#1841)

* add a failing test

* fix the argument escaping

Author: adamsitnik

src/BenchmarkDotNet/Extensions/StringAndTextExtensions.cs

@@ -3,6 +3,7 @@
 using System.IO;
 using System.Linq;
 using System.Text;
+using System.Text.RegularExpressions;
 
 namespace BenchmarkDotNet.Extensions
 {
@@ -14,7 +15,17 @@ private static readonly Lazy<Dictionary<string, string>> InvalidFileNameCharacte
 
         internal static string ToLowerCase(this bool value) => value ? "true" : "false"; // to avoid .ToString().ToLower() allocation
 
-        internal static string Escape(this string path) => "\"" + path + "\"";
+        // source: https://stackoverflow.com/a/12364234/5852046
+        internal static string Escape(this string cliArg)
+        {
+            if (string.IsNullOrEmpty(cliArg))
+                return cliArg;
+
+            string value = Regex.Replace(cliArg, @"(\\*)" + "\"", @"$1\$0");
+            value = Regex.Replace(value, @"^(.*\s.*?)(\\*)$", "\"$1$2$2\"", RegexOptions.Singleline);
+
+            return value;
+        }
 
         /// <summary>
         /// replaces all invalid file name chars with their number representation

tests/BenchmarkDotNet.IntegrationTests/ArgumentsTests.cs

@@ -770,6 +770,18 @@ public void Test(string first, string second)
             }
         }
 
+        [Theory, MemberData(nameof(GetToolchains))]
+        public void ComplexStringPattersAreSupported(IToolchain toolchain) => CanExecute<Perf_Regex_Industry_RustLang_Sherlock>(toolchain);
+
+        public class Perf_Regex_Industry_RustLang_Sherlock
+        {
+            [Params(@"[""'][^""']{0,30}[?!.][""']")]
+            public string Pattern { get; set; }
+
+            [Benchmark]
+            public int Consume() => Pattern.Length;
+        }
+
         [Fact]
         public void UnusedDisposableParamsAreDisposed() => CanExecute<WithDisposableArguments>(Job.Default.GetToolchain());