Use Pipes for host and benchmark process communication (#2092)

Author: adamsitnik

src/BenchmarkDotNet.Diagnostics.Windows/ConcurrencyVisualizerProfiler.cs

@@ -60,8 +60,6 @@ public void DisplayResults(ILogger logger)
             logger.WriteLineInfo("DO remember that this Diagnoser just tries to mimic the CVCollectionCmd.exe and you need to have Visual Studio with Concurrency Visualizer plugin installed to visualize the data.");
         }
 
-        public bool RequiresBlockingAcknowledgments(BenchmarkCase benchmarkCase) => true;
-
         public void Handle(HostSignal signal, DiagnoserActionParameters parameters)
         {
             etwProfiler.Handle(signal, parameters);

src/BenchmarkDotNet.Diagnostics.Windows/EtwDiagnoser.cs

@@ -21,7 +21,6 @@ namespace BenchmarkDotNet.Diagnostics.Windows
         protected readonly Dictionary<BenchmarkCase, int> BenchmarkToProcess = new Dictionary<BenchmarkCase, int>();
         protected readonly ConcurrentDictionary<int, TStats> StatsPerProcess = new ConcurrentDictionary<int, TStats>();
 
-        public bool RequiresBlockingAcknowledgments(BenchmarkCase benchmarkCase) => true;
         public virtual RunMode GetRunMode(BenchmarkCase benchmarkCase) => RunMode.ExtraRun;
 
         public virtual IEnumerable<IExporter> Exporters => Array.Empty<IExporter>();

src/BenchmarkDotNet.Diagnostics.Windows/EtwProfiler.cs

@@ -60,8 +60,6 @@ public EtwProfiler(EtwProfilerConfig config)
         public IEnumerable<ValidationError> Validate(ValidationParameters validationParameters)
             => HardwareCounters.Validate(validationParameters, mandatory: false);
 
-        public bool RequiresBlockingAcknowledgments(BenchmarkCase benchmarkCase) => false;
-
         public void Handle(HostSignal signal, DiagnoserActionParameters parameters)
         {
             // it's crucial to start the trace before the process starts and stop it after the benchmarked process stops to have all of the necessary events in the trace file!

src/BenchmarkDotNet.Diagnostics.Windows/NativeMemoryProfiler.cs

@@ -46,8 +46,6 @@ public void DisplayResults(ILogger resultLogger)
                 resultLogger.Write(line.Kind, line.Text);
         }
 
-        public bool RequiresBlockingAcknowledgments(BenchmarkCase benchmarkCase) => etwProfiler.RequiresBlockingAcknowledgments(benchmarkCase);
-
         public void Handle(HostSignal signal, DiagnoserActionParameters parameters) => etwProfiler.Handle(signal, parameters);
 
         public RunMode GetRunMode(BenchmarkCase benchmarkCase) => etwProfiler.GetRunMode(benchmarkCase);

src/BenchmarkDotNet/Code/CodeGenerator.cs

@@ -79,9 +79,6 @@ internal static string Generate(BuildPartition buildPartition)
             else if (buildPartition.IsWasm)
                 extraDefines.Add("#define WASM");
 
-            if (buildPartition.NoAcknowledgments)
-                extraDefines.Add("#define NO_ACK");
-
             string benchmarkProgramContent = new SmartStringBuilder(ResourceHelper.LoadTemplate("BenchmarkProgram.txt"))
                 .Replace("$ShadowCopyDefines$", useShadowCopy ? "#define SHADOWCOPY" : null).Replace("$ShadowCopyFolderPath$", shadowCopyFolderPath)
                 .Replace("$ExtraDefines$", string.Join(Environment.NewLine, extraDefines))

src/BenchmarkDotNet/Diagnosers/CompositeDiagnoser.cs

@@ -31,9 +31,6 @@ public IEnumerable<IExporter> Exporters
         public IEnumerable<IAnalyser> Analysers
             => diagnosers.SelectMany(diagnoser => diagnoser.Analysers);
 
-        public bool RequiresBlockingAcknowledgments(BenchmarkCase benchmarkCase)
-            => diagnosers.Any(diagnoser => diagnoser.RequiresBlockingAcknowledgments(benchmarkCase));
-
         public void Handle(HostSignal signal, DiagnoserActionParameters parameters)
         {
             foreach (var diagnoser in diagnosers)

src/BenchmarkDotNet/Diagnosers/EventPipeProfiler.cs

@@ -69,8 +69,6 @@ public IEnumerable<ValidationError> Validate(ValidationParameters validationPara
             }
         }
 
-        public bool RequiresBlockingAcknowledgments(BenchmarkCase benchmarkCase) => true;
-
         public void Handle(HostSignal signal, DiagnoserActionParameters parameters)
         {
             if (signal != HostSignal.BeforeAnythingElse)

src/BenchmarkDotNet/Diagnosers/IDiagnoser.cs

@@ -20,8 +20,6 @@ public interface IDiagnoser
 
         RunMode GetRunMode(BenchmarkCase benchmarkCase);
 
-        bool RequiresBlockingAcknowledgments(BenchmarkCase benchmarkCase);
-
         void Handle(HostSignal signal, DiagnoserActionParameters parameters);
 
         IEnumerable<Metric> ProcessResults(DiagnoserResults results);

src/BenchmarkDotNet/Diagnosers/MemoryDiagnoser.cs

@@ -30,7 +30,6 @@ public void DisplayResults(ILogger logger) { }
         public IEnumerable<ValidationError> Validate(ValidationParameters validationParameters) => Array.Empty<ValidationError>();
 
         // the action takes places in other process, and the values are gathered by Engine
-        public bool RequiresBlockingAcknowledgments(BenchmarkCase benchmarkCase) => false;
         public void Handle(HostSignal signal, DiagnoserActionParameters parameters) { }
 
         public IEnumerable<Metric> ProcessResults(DiagnoserResults diagnoserResults)

src/BenchmarkDotNet/Diagnosers/ThreadingDiagnoser.cs

@@ -29,8 +29,6 @@ public void DisplayResults(ILogger logger) { }
 
         public RunMode GetRunMode(BenchmarkCase benchmarkCase) => RunMode.NoOverhead;
 
-        public bool RequiresBlockingAcknowledgments(BenchmarkCase benchmarkCase) => false;
-
         public void Handle(HostSignal signal, DiagnoserActionParameters parameters) { }
 
         public IEnumerable<Metric> ProcessResults(DiagnoserResults results)