Fix warnings (#1896)

* fix code warnings

* fix XML comments warnings

Author: adamsitnik

src/BenchmarkDotNet/Attributes/Filters/OperatingSystemsArchitectureFilterAttribute.cs

@@ -12,6 +12,7 @@ public class OperatingSystemsArchitectureFilterAttribute : FilterConfigBaseAttri
         public OperatingSystemsArchitectureFilterAttribute() { }
 
         /// <param name="allowed">if set to true, the architectures are enabled, if set to false, disabled</param>
+        /// <param name="architectures">the architecture(s) for which the filter should be applied</param>
         public OperatingSystemsArchitectureFilterAttribute(bool allowed, params Architecture[] architectures)
             : base(new SimpleFilter(_ =>
             {

src/BenchmarkDotNet/Attributes/Filters/OperatingSystemsFilterAttribute.cs

@@ -26,6 +26,7 @@ public class OperatingSystemsFilterAttribute : FilterConfigBaseAttribute
         public OperatingSystemsFilterAttribute() { }
 
         /// <param name="allowed">if set to true, the OSes beloning to platforms are enabled, if set to false, disabled</param>
+        /// <param name="platforms">the platform(s) for which the filter should be applied</param>
         public OperatingSystemsFilterAttribute(bool allowed, params OS[] platforms)
             : base(new SimpleFilter(_ =>
             {

src/BenchmarkDotNet/Environments/OsBrandStringHelper.cs

@@ -139,7 +139,7 @@ public string ToPrettifiedString([CanBeNull] int? ubr)
 
             // See https://en.wikipedia.org/wiki/Windows_10_version_history
             // See https://en.wikipedia.org/wiki/Windows_11_version_history
-            private static readonly List<Windows1XVersion> WellKnownVersions = new()
+            private static readonly List<Windows1XVersion> WellKnownVersions = new ()
             {
                 // Windows 10
                 new Windows1XVersion("1507", "Threshold 1", "RTM", 10240),

src/BenchmarkDotNet/Environments/Runtimes/WasmRuntime.cs

@@ -1,9 +1,7 @@
 using System;
 using System.ComponentModel;
 using System.IO;
-using BenchmarkDotNet.Extensions;
 using BenchmarkDotNet.Jobs;
-using BenchmarkDotNet.Toolchains.MonoWasm;
 
 namespace BenchmarkDotNet.Environments
 {
@@ -23,12 +21,12 @@ public class WasmRuntime : Runtime, IEquatable<WasmRuntime>
         /// <summary>
         /// creates new instance of WasmRuntime
         /// </summary>
-        /// <param name="mainJs">MANDATORY path to the main.js file.</param>
         /// <param name="javaScriptEngine">Full path to a java script engine used to run the benchmarks. "v8" by default</param>
         /// <param name="javaScriptEngineArguments">Arguments for the javascript engine. "--expose_wasm" by default</param>
         /// <param name="msBuildMoniker">moniker, default: "net5.0"</param>
         /// <param name="displayName">default: "Wasm"</param>
-        /// <remarks>path to mainJs MUST be provided</remarks>
+        /// <param name="aot">Specifies whether AOT or Interpreter (default) project should be generated.</param>
+        /// <param name="runtimeSrcDir">The path to runtime source directory.</param>
         public WasmRuntime(string msBuildMoniker = "net5.0", string displayName = "Wasm", string javaScriptEngine = "v8", string javaScriptEngineArguments = "--expose_wasm", bool aot = false, DirectoryInfo runtimeSrcDir = null) : base(RuntimeMoniker.Wasm, msBuildMoniker, displayName)
         {
             if (!string.IsNullOrEmpty(javaScriptEngine) && javaScriptEngine != "v8" && !File.Exists(javaScriptEngine))

src/BenchmarkDotNet/Order/CategoryComparer.cs

@@ -7,7 +7,7 @@ namespace BenchmarkDotNet.Order
     internal class CategoryComparer : IComparer<string[]>
     {
         private const string Separator = "§";
-        public static readonly CategoryComparer Instance = new();
+        public static readonly CategoryComparer Instance = new ();
 
         public int Compare(string[] x, string[] y)
         {

src/BenchmarkDotNet/Running/BenchmarkRunnerDirty.cs

@@ -29,7 +29,7 @@ public static Summary Run(Type type, IConfig config = null, string[] args = null
             using (DirtyAssemblyResolveHelper.Create())
                 return RunWithExceptionHandling(() => RunWithDirtyAssemblyResolveHelper(type, config, args));
         }
-        
+
         [PublicAPI]
         public static Summary[] Run(Type[] types, IConfig config = null, string[] args = null)
         {
@@ -95,7 +95,7 @@ private static Summary[] RunWithDirtyAssemblyResolveHelper(Assembly assembly, IC
             => args == null
                 ? BenchmarkRunnerClean.Run(assembly.GetRunnableBenchmarks().Select(type => BenchmarkConverter.TypeToBenchmarks(type, config)).ToArray())
                 : new BenchmarkSwitcher(assembly).RunWithDirtyAssemblyResolveHelper(args, config, false).ToArray();
-        
+
         [MethodImpl(MethodImplOptions.NoInlining)]
         private static Summary[] RunWithDirtyAssemblyResolveHelper(Type[] types, IConfig config, string[] args)
             => args == null

src/BenchmarkDotNet/Toolchains/CoreRt/CoreRtToolchain.cs

@@ -35,6 +35,8 @@ public class CoreRtToolchain : Toolchain
         /// compiled as net6.0, targets latest (6.0.0-*) CoreRT build from the new feed: https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-experimental/nuget/v3/index.json
         /// </summary>
         public static readonly IToolchain Core60 = CreateBuilder().UseCoreRtNuGet().TargetFrameworkMoniker("net6.0").ToToolchain();
+        /// <summary>
+        /// compiled as net7.0, targets latest (6.0.0-*) CoreRT build from the new feed: https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-experimental/nuget/v3/index.json
         /// </summary>
         public static readonly IToolchain Core70 = CreateBuilder().UseCoreRtNuGet().TargetFrameworkMoniker("net7.0").ToToolchain();
 

tests/BenchmarkDotNet.Tests/Order/DefaultOrdererTests.cs

@@ -17,10 +17,10 @@ namespace BenchmarkDotNet.Tests.Order
 {
     public class DefaultOrdererTests
     {
-        private static Summary CreateMockSummary() => new("", ImmutableArray<BenchmarkReport>.Empty, HostEnvironmentInfo.GetCurrent(),
+        private static Summary CreateMockSummary() => new ("", ImmutableArray<BenchmarkReport>.Empty, HostEnvironmentInfo.GetCurrent(),
             "", "", TimeSpan.Zero, CultureInfo.InvariantCulture, ImmutableArray<ValidationError>.Empty);
 
-        private static BenchmarkCase CreateBenchmarkCase(string category, int parameter, params BenchmarkLogicalGroupRule[] rules) => new(
+        private static BenchmarkCase CreateBenchmarkCase(string category, int parameter, params BenchmarkLogicalGroupRule[] rules) => new (
             new Descriptor(null, null, categories: new[] { category }),
             new Job(),
             new ParameterInstances(new[]

tests/BenchmarkDotNet.Tests/ParamsSourceTests.cs

@@ -14,7 +14,7 @@ public void NullIsSupportedAsElementOfParamsSource()
         {
             BenchmarkConverter.TypeToBenchmarks(typeof(ParamsSourceWithNull));
         }
-        
+
         public class ParamsSourceWithNull
         {
             public static IEnumerable<object> Values()
@@ -30,6 +30,6 @@ public static IEnumerable<object> Values()
 
             [Benchmark]
             public object FooBar() => O;
-        }   
+        }
     }
 }